walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Resolve CID 1379700 

Ensure the string is null-terminated
This commit is contained in:
Dmitry-Me 2017-08-21 18:25:12 +03:00
parent b1b82319b1
commit 2820febaff
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
cli/threadexecutor.cpp
View File

@ -102,11 +102,15 @@ int ThreadExecutor::handleRead(int rpipe, unsigned int &result)
std::exit(0); std::exit(0);
} }
char *buf = new char[len]; // Don't rely on incoming data being null-terminated.
if (read(rpipe, buf, len) <= 0) { // Allocate +1 element and null-terminate the buffer.
char *buf = new char[len + 1];
const ssize_t readIntoBuf = read(rpipe, buf, len);
if (readIntoBuf <= 0) {
std::cerr << "#### You found a bug from cppcheck.\nThreadExecutor::handleRead error, type was:" << type << std::endl; std::cerr << "#### You found a bug from cppcheck.\nThreadExecutor::handleRead error, type was:" << type << std::endl;
std::exit(0); std::exit(0);
} }
buf[readIntoBuf] = 0;
if (type == REPORT_OUT) { if (type == REPORT_OUT) {
_errorLogger.reportOut(buf); _errorLogger.reportOut(buf);