Fix Cppcheck performance warning stlFindInsert properly

2020-12-19 22:23:25 +01:00 · 2020-12-19 22:23:25 +01:00 · 28e33ef0b9
parent 079255d913
commit 28e33ef0b9
1 changed files with 3 additions and 3 deletions
--- a/lib/settings.cpp
+++ b/lib/settings.cpp
@ -197,9 +197,9 @@ void Settings::loadSummaries()
            // noreturn..
            if (line.find(" noreturn:[") != std::string::npos || line.find(" call:[") != std::string::npos)
                summaryNoreturn[functionName] = true;
-            else if (summaryNoreturn.find(functionName) == summaryNoreturn.end())
-                // cppcheck-suppress stlFindInsert
-                summaryNoreturn[functionName] = false;
+            else
+                // If there is a value for function already keep it, otherwise insert false
+                summaryNoreturn.emplace(std::pair<std::string,bool>(functionName, false));
        }
    }
 }