walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Fix Cppcheck performance warning stlFindInsert properly

This commit is contained in:
Daniel Marjamäki 2020-12-19 22:23:25 +01:00
parent 079255d913
commit 28e33ef0b9
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/settings.cpp
View File

@ -197,9 +197,9 @@ void Settings::loadSummaries()
// noreturn.. // noreturn..
if (line.find(" noreturn:[") != std::string::npos || line.find(" call:[") != std::string::npos) if (line.find(" noreturn:[") != std::string::npos || line.find(" call:[") != std::string::npos)
summaryNoreturn[functionName] = true; summaryNoreturn[functionName] = true;
else if (summaryNoreturn.find(functionName) == summaryNoreturn.end()) else
// cppcheck-suppress stlFindInsert // If there is a value for function already keep it, otherwise insert false
summaryNoreturn[functionName] = false; summaryNoreturn.emplace(std::pair<std::string,bool>(functionName, false));
} }
} }
} }