walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Fixed #3328 (False negative: out of bounds)

This commit is contained in:
Daniel Marjamäki 2011-11-19 15:28:06 +01:00
parent fc42fc956c
commit 2a5b4b1842
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/checkbufferoverrun.cpp
View File

@ -1073,7 +1073,7 @@ void CheckBufferOverrun::checkScope(const Token *tok, const ArrayInfo &arrayInfo
continue; continue;
// Is totalIndex in bounds? // Is totalIndex in bounds?
if (totalIndex > totalElements) { if (totalIndex >= totalElements) {
arrayIndexOutOfBoundsError(tok, arrayInfo, indexes); arrayIndexOutOfBoundsError(tok, arrayInfo, indexes);
} }
// Is any array index out of bounds? // Is any array index out of bounds?
@ -1249,7 +1249,7 @@ void CheckBufferOverrun::checkGlobalAndLocalVariable()
for (unsigned int i = 1; i <= _tokenizer->varIdCount(); i++) { for (unsigned int i = 1; i <= _tokenizer->varIdCount(); i++) {
const Variable *var = _tokenizer->getSymbolDatabase()->getVariableFromVarId(i); const Variable *var = _tokenizer->getSymbolDatabase()->getVariableFromVarId(i);
if (var && var->isArray() && var->dimension(0) > 0) { if (var && var->isArray() && var->dimension(0) > 0) {
ArrayInfo arrayInfo(var, _tokenizer); const ArrayInfo arrayInfo(var, _tokenizer);
const Token *tok = var->nameToken(); const Token *tok = var->nameToken();
while (tok && tok->str() != ";") { while (tok && tok->str() != ";") {
if (tok->str() == "{") { if (tok->str() == "{") {