walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

misra.py: Fix mutable default argument in "misra_17_2()" (#2355) 

PyCharm inspection warns for argument `visited=set()` with
"Default argument is mutable".
According to different sources one should nearly never use mutable
default arguments:
https://docs.python-guide.org/writing/gotchas/#mutable-default-arguments
https://dev.to/florimondmanca/python-mutable-defaults-are-the-source-of-all-evil-6kk
This commit is contained in:
Sebastian 2019-11-13 14:45:34 +01:00 committed by GitHub
parent 177eed122a
commit 2b1a1a2a38
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
addons/misra.py
View File

@ -1645,7 +1645,9 @@ class MisraChecker:
def misra_17_2(self, data): def misra_17_2(self, data):
# find recursions.. # find recursions..
def find_recursive_call(search_for_function, direct_call, calls_map, visited=set()): def find_recursive_call(search_for_function, direct_call, calls_map, visited=None):
if visited is None:
visited = set()
if direct_call == search_for_function: if direct_call == search_for_function:
return True return True
for indirect_call in calls_map.get(direct_call, []): for indirect_call in calls_map.get(direct_call, []):