Uninitialized variables; use AST
This commit is contained in:
parent
e73057eb44
commit
2c155a7a78
|
@ -1109,14 +1109,14 @@ bool CheckUninitVar::isVariableUsage(const Token *vartok, bool pointer, Alloc al
|
||||||
}
|
}
|
||||||
|
|
||||||
// is there something like: ; "*((&var ..expr.. =" => the variable is assigned
|
// is there something like: ; "*((&var ..expr.. =" => the variable is assigned
|
||||||
if (vartok->previous()->str() == "&" && !vartok->previous()->astOperand2())
|
if (vartok->astParent()->isUnaryOp("&"))
|
||||||
return false;
|
return false;
|
||||||
|
|
||||||
// bailout to avoid fp for 'int x = 2 + x();' where 'x()' is a unseen preprocessor macro (seen in linux)
|
// bailout to avoid fp for 'int x = 2 + x();' where 'x()' is a unseen preprocessor macro (seen in linux)
|
||||||
if (!pointer && vartok->next() && vartok->next()->str() == "(")
|
if (!pointer && vartok->next() && vartok->next()->str() == "(")
|
||||||
return false;
|
return false;
|
||||||
|
|
||||||
if (alloc != NO_ALLOC && vartok->previous()->str() == "*") {
|
if (alloc != NO_ALLOC && vartok->astParent()->isUnaryOp("*")) {
|
||||||
// TestUninitVar::isVariableUsageDeref()
|
// TestUninitVar::isVariableUsageDeref()
|
||||||
const Token *parent = vartok->previous()->astParent();
|
const Token *parent = vartok->previous()->astParent();
|
||||||
if (parent && parent->str() == "=" && parent->astOperand1() == vartok->previous())
|
if (parent && parent->str() == "=" && parent->astOperand1() == vartok->previous())
|
||||||
|
@ -1126,7 +1126,7 @@ bool CheckUninitVar::isVariableUsage(const Token *vartok, bool pointer, Alloc al
|
||||||
return true;
|
return true;
|
||||||
}
|
}
|
||||||
|
|
||||||
if (vartok->previous()->str() != "&" || !Token::Match(vartok->tokAt(-2), "[(,=?:]"))
|
if (!vartok->astParent()->isUnaryOp("&") || !Token::Match(vartok->tokAt(-2), "[(,=?:]"))
|
||||||
return alloc == NO_ALLOC;
|
return alloc == NO_ALLOC;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue