walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

CheckAutoVariables: change type of vp_list member to std::set. 

Change type of vda_list from std::list to std::set. It allows to us
use find() method instead of self-written loop which may be slow.

No functional change.
This commit is contained in:
Slava Semushin 2009-08-16 16:16:35 +07:00
parent 053e6f8b9a
commit 2dccf150ab
2 changed files with 5 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/checkautovariables.cpp
View File

@ -43,24 +43,10 @@ static CheckAutoVariables instance;
bool CheckAutoVariables::errorAv(const Token* left, const Token* right)
{
const std::string left_var(left->str());
std::list<std::string>::iterator it_fp;
for (it_fp = fp_list.begin(); it_fp != fp_list.end(); ++it_fp)
if (fp_list.find(left->str()) == fp_list.end())
{
std::string vname(*it_fp);
//The left argument is a formal parameter
if (vname == left_var)
{
//cout << "Beccato" << endl;
break;
}
}
//The left argument is NOT a formal parameter
if (it_fp == fp_list.end())
return false;
}
return isAutoVar(right->varId());
}
@ -141,13 +127,11 @@ void CheckAutoVariables::autoVariables()
}
else if (begin_function && begin_function_decl && Token::Match(tok, "%type% * * %var%"))
{
std::string var_name(tok->tokAt(3)->str());
fp_list.push_back(var_name);
fp_list.insert(tok->tokAt(3)->str());
}
else if (begin_function && begin_function_decl && Token::Match(tok, "%type% * %var% ["))
{
std::string var_name(tok->tokAt(2)->str());
fp_list.push_back(var_name);
fp_list.insert(tok->tokAt(2)->str());
}
else if (begin_function && tok->str() == "(")
begin_function_decl = true;

3
src/checkautovariables.h
View File

@ -24,7 +24,6 @@
#include "check.h"
#include "token.h"
#include <list>
#include <set>
/// @addtogroup Checks
@ -57,7 +56,7 @@ public:
void returnPointerToLocalArray();
private:
std::list<std::string> fp_list;
std::set<std::string> fp_list;
std::set<unsigned int> vd_list;
std::set<unsigned int> vda_list;
bool errorAv(const Token* left, const Token* right);