walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Fixed #3916 (false positive: uninitialized variable when using assignment and , in rhs)

This commit is contained in:
Daniel Marjamäki 2012-06-27 20:44:19 +02:00
parent 9da3373876
commit 2e3a08a8c1
2 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/checkuninitvar.cpp
View File

@ -412,7 +412,7 @@ private:
if (var2->isPointer()) if (var2->isPointer())
checks.push_back(new UninitVar(owner, var2, symbolDatabase, isC)); checks.push_back(new UninitVar(owner, var2, symbolDatabase, isC));
else if (var2->typeEndToken()->str() != ">") { else if (var2->typeEndToken()->str() != ">") {
bool stdtype = isC; bool stdtype = false; // TODO: change to isC to handle unknown types better
for (const Token* tok2 = var2->typeStartToken(); tok2 != var2->nameToken(); tok2 = tok2->next()) { for (const Token* tok2 = var2->typeStartToken(); tok2 != var2->nameToken(); tok2 = tok2->next()) {
if (tok2->isStandardType()) { if (tok2->isStandardType()) {
stdtype = true; stdtype = true;

17
test/testuninitvar.cpp
View File

@ -84,13 +84,6 @@ private:
"}\n"); "}\n");
ASSERT_EQUALS("[test.cpp:3]: (error) Uninitialized variable: a\n", errout.str()); ASSERT_EQUALS("[test.cpp:3]: (error) Uninitialized variable: a\n", errout.str());
checkUninitVar("void foo() {\n"
" dfs a;\n"
" b = c - a;\n"
"}\n",
"test.c");
ASSERT_EQUALS("[test.c:3]: (error) Uninitialized variable: a\n", errout.str());
checkUninitVar("void foo() {\n" checkUninitVar("void foo() {\n"
" int a;\n" " int a;\n"
" b = a - c;\n" " b = a - c;\n"
@ -310,7 +303,15 @@ private:
" return ret;\n" " return ret;\n"
"}\n", "}\n",
"test.c"); "test.c");
ASSERT_EQUALS("[test.c:4]: (error) Uninitialized variable: ret\n", errout.str()); TODO_ASSERT_EQUALS("[test.c:4]: (error) Uninitialized variable: ret\n", "", errout.str());
// #3916 - avoid false positive
checkUninitVar("void f(float x) {\n"
" union lf { long l; float f; } u_lf;\n"
" float hx = (u_lf.f = (x), u_lf.l);\n"
"}\n",
"test.c");
ASSERT_EQUALS("", errout.str());
} }
checkUninitVar("void a()\n" checkUninitVar("void a()\n"