Update workflows to Ubuntu 20.04 (#2948)

.github/workflows/CI-unixish.yml

@@ -103,7 +103,7 @@ jobs:
 
       # Run self check after "Build GUI" to include generated headers in analysis
       - name: Self check
-        if: matrix.os == 'ubuntu-18.04'
+        if: matrix.os == 'ubuntu-20.04'
         run: |
           # compile with verification and ast matchers
           make clean
@@ -118,14 +118,14 @@ jobs:
           ./cppcheck -q -j$(nproc) --template=gcc -D__CPPCHECK__ --error-exitcode=1 --inline-suppr --suppressions-list=.travis_suppressions --library=cppcheck-lib -Ilib -Iexternals/simplecpp/ -Iexternals/tinyxml2/ -Icli -Igui --inconclusive --enable=style,performance,portability,warning,internal --exception-handling test/*.cpp tools
 
       - name: Build triage on ubuntu
-        if: matrix.os == 'ubuntu-18.04'
+        if: matrix.os == 'ubuntu-20.04'
         run: |
           pushd tools/triage
           qmake
           make -j$(nproc)
 
       - name: Build Fuzzer
-        if: matrix.os == 'ubuntu-18.04'
+        if: matrix.os == 'ubuntu-20.04'
         run: |
           g++ -fsyntax-only -std=c++11 -Ilib oss-fuzz/*.cpp
 

.github/workflows/asan.yml

@@ -7,12 +7,7 @@ on: [push, pull_request]
 jobs:
   build:
 
-    strategy:
-      matrix:
-        os: [ubuntu-latest]
-      fail-fast: false # not worthwhile...
-
-    runs-on: ${{ matrix.os }}
+    runs-on: ubuntu-20.04
 
     steps:
       - uses: actions/checkout@v2
@@ -21,11 +16,9 @@ jobs:
         run: |
           sudo apt-get update
           sudo apt-get install libz3-4 libz3-dev
-          cp externals/z3_version_old.h externals/z3_version.h
 
       - name: Build
         run: |
-          cp externals/z3_version_old.h externals/z3_version.h
           CC=clang CXX=clang++ CXXFLAGS="-fsanitize=address -O1 -g3 -DCPPCHK_GLIBCXX_DEBUG" make cppcheck testrunner -j$(nproc) USE_Z3=yes HAVE_RULES=yes MATCHCOMPILER=yes
 
       - name: Run tests

.github/workflows/buildman.yml

@@ -4,7 +4,7 @@ on: [push, pull_request]
 
 jobs:
   convert_via_pandoc:
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-20.04
     steps:
       - uses: actions/checkout@v2
 

.github/workflows/codeql-analysis.yml

@@ -5,7 +5,7 @@ on: [push, pull_request]
 jobs:
   analyze:
     name: Analyze
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-20.04
 
     strategy:
       fail-fast: false
@@ -24,8 +24,7 @@ jobs:
       run: |
          sudo apt-get update
          sudo apt-get install libxml2-utils
-         sudo apt-get install z3 libz3-dev
-         cp externals/z3_version_old.h externals/z3_version.h
+         sudo apt-get install libz3-dev libz3-4
 
     # Initializes the CodeQL tools for scanning.
     - name: Initialize CodeQL

.github/workflows/coverage.yml

@@ -7,7 +7,7 @@ on: [push]
 jobs:
   build:
 
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-20.04
 
     steps:
       - uses: actions/checkout@v2
@@ -16,13 +16,12 @@ jobs:
         run: |
           sudo apt-get update
           sudo apt-get install libxml2-utils
-          sudo apt-get install z3 libz3-dev
+          sudo apt-get install libz3-dev libz3-4
           sudo apt-get install lcov
           pip install lcov_cobertura
 
       - name: Compile instrumented
         run: |
-          cp externals/z3_version_old.h externals/z3_version.h
           make test CXXFLAGS="-g -fprofile-arcs -ftest-coverage" USE_Z3=yes HAVE_RULES=yes -j$(nproc)
           
       - name: Generate coverage report
@@ -35,7 +34,7 @@ jobs:
           lcov --extract lcov_tmp.info "$(pwd)/*" --output-file lcov.info
           genhtml lcov.info -o coverage_report --frame --legend --demangle-cpp
           
-      - uses: actions/upload-artifact@v1
+      - uses: actions/upload-artifact@v2
         with:
          name: Coverage results
          path: coverage_report

.github/workflows/irc.yml

@@ -4,7 +4,7 @@ on: [pull_request, create]
 jobs:
   test:
     if: github.repository == 'danmar/cppcheck'
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-20.04
     steps:
       - name: irc pull request
         uses: rectalogic/notify-irc@v1

.github/workflows/scriptcheck.yml

@@ -7,18 +7,12 @@ on: [push, pull_request]
 jobs:
   build:
 
-    strategy:
-      matrix:
-        os: [ubuntu-latest]
-      fail-fast: false # not worthwhile...
-
-    runs-on: ${{ matrix.os }}
+    runs-on: ubuntu-20.04
 
     steps:
       - uses: actions/checkout@v2
 
       - name: Install missing software on ubuntu
-        if: matrix.os == 'ubuntu-latest'
         run: |
           sudo apt-get update
           sudo apt-get install shellcheck

.github/workflows/ubsan.yml

@@ -7,12 +7,7 @@ on: [push, pull_request]
 jobs:
   build:
 
-    strategy:
-      matrix:
-        os: [ubuntu-latest]
-      fail-fast: false # not worthwhile...
-
-    runs-on: ${{ matrix.os }}
+    runs-on: ubuntu-20.04
 
     steps:
       - uses: actions/checkout@v2
@@ -21,11 +16,9 @@ jobs:
         run: |
           sudo apt-get update
           sudo apt-get install libz3-4 libz3-dev
-          cp externals/z3_version_old.h externals/z3_version.h
 
       - name: Build
         run: |
-          cp externals/z3_version_old.h externals/z3_version.h
           CC=clang CXX=clang++ CXXFLAGS="-fsanitize=undefined -fsanitize=nullability -O1 -g3 -DCPPCHK_GLIBCXX_DEBUG" make cppcheck testrunner -j$(nproc) USE_Z3=yes HAVE_RULES=yes MATCHCOMPILER=yes
 
       - name: Run tests