From b5c7316666d072ce448e0aea96d981065e777da6 Mon Sep 17 00:00:00 2001
From: Slava Semushin <php-coder@altlinux.ru>
Date: Sat, 23 May 2009 17:20:26 +0700
Subject: [PATCH 1/2] Fixed ticket #327 (File descriptor leak not detected when
 feof() used)

Thanks to aggro80@ for help.

http://apps.sourceforge.net/trac/cppcheck/ticket/327
---
 src/checkmemoryleak.cpp |  2 +-
 test/testmemleak.cpp    | 11 +++++++++++
 2 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/src/checkmemoryleak.cpp b/src/checkmemoryleak.cpp
index 35a14a35c..2a38fd8cd 100644
--- a/src/checkmemoryleak.cpp
+++ b/src/checkmemoryleak.cpp
@@ -214,7 +214,7 @@ const char * CheckMemoryLeakClass::call_func(const Token *tok, std::list<const T
         return 0;
 
     // I/O functions that are not allocating nor deallocating memory..
-    if (Token::Match(tok, "fgets|fgetc|fputs|fputc|printf"))
+    if (Token::Match(tok, "fgets|fgetc|fputs|fputc|feof|printf"))
         return 0;
 
     // Convert functions that are not allocating nor deallocating memory..
diff --git a/test/testmemleak.cpp b/test/testmemleak.cpp
index f1b3e0f58..2d41057af 100644
--- a/test/testmemleak.cpp
+++ b/test/testmemleak.cpp
@@ -216,6 +216,7 @@ private:
 
         TEST_CASE(strndup_function);
         TEST_CASE(fcloseall_function);
+        TEST_CASE(feof_function);
         TEST_CASE(pointer_to_pointer);
     }
 
@@ -2189,6 +2190,16 @@ private:
         ASSERT_EQUALS(std::string(""), errout.str());
     }
 
+    void feof_function()
+    {
+        check("void f()\n"
+              "{\n"
+              "FILE *f = fopen(fname, str);\n"
+              "feof(f);\n"
+              "}\n");
+        ASSERT_EQUALS(std::string("[test.cpp:5]: (error) Resource leak: f\n"), errout.str());
+    }
+
     void pointer_to_pointer()
     {
         check("void f(char **data)\n"

From bfd49e21e72ab2cbd4fb0137ebc11f271f25673e Mon Sep 17 00:00:00 2001
From: Slava Semushin <php-coder@altlinux.ru>
Date: Sat, 23 May 2009 18:01:18 +0700
Subject: [PATCH 2/2] Added 17 functions which work with FILE structure to
 white list.

Inspired by previous commit.
---
 src/checkmemoryleak.cpp |  4 +++-
 test/testmemleak.cpp    | 23 ++++++++++++++++++++---
 2 files changed, 23 insertions(+), 4 deletions(-)

diff --git a/src/checkmemoryleak.cpp b/src/checkmemoryleak.cpp
index 2a38fd8cd..fe65b980b 100644
--- a/src/checkmemoryleak.cpp
+++ b/src/checkmemoryleak.cpp
@@ -214,7 +214,9 @@ const char * CheckMemoryLeakClass::call_func(const Token *tok, std::list<const T
         return 0;
 
     // I/O functions that are not allocating nor deallocating memory..
-    if (Token::Match(tok, "fgets|fgetc|fputs|fputc|feof|printf"))
+    if (Token::Match(tok, "fgets|fgetc|fputs|fputc|feof|ferror|clearerr|printf|fprintf") ||
+        Token::Match(tok, "fread|fwrite|fflush|fseek|fseeko|ftell|ftello|fsetpos|fgetpos") ||
+        Token::Match(tok, "setvbuf|setbuf|setbuffer|setlinebuf|rewind"))
         return 0;
 
     // Convert functions that are not allocating nor deallocating memory..
diff --git a/test/testmemleak.cpp b/test/testmemleak.cpp
index 2d41057af..b5fddb0b0 100644
--- a/test/testmemleak.cpp
+++ b/test/testmemleak.cpp
@@ -216,7 +216,7 @@ private:
 
         TEST_CASE(strndup_function);
         TEST_CASE(fcloseall_function);
-        TEST_CASE(feof_function);
+        TEST_CASE(file_functions);
         TEST_CASE(pointer_to_pointer);
     }
 
@@ -2190,14 +2190,31 @@ private:
         ASSERT_EQUALS(std::string(""), errout.str());
     }
 
-    void feof_function()
+    void file_functions()
     {
         check("void f()\n"
               "{\n"
               "FILE *f = fopen(fname, str);\n"
               "feof(f);\n"
+              "clearerr(in);\n"
+              "ferror(in);\n"
+              "fread(ptr, 10, 1, in);\n"
+              "fwrite(ptr, 10, 1, in);\n"
+              "fflush(in);\n"
+              "setbuf(in, buf);\n"
+              "setbuffer(in, buf, 100);\n"
+              "setlinebuf(in);\n"
+              "setvbuf(in, buf, _IOLBF, 0);\n"
+              "fseek(in, 10, SEEK_SET);\n"
+              "fseeko(in, 10, SEEK_SET);\n"
+              "ftell(in);\n"
+              "ftello(in);\n"
+              "rewind(in);\n"
+              "fsetpos(in, 0);\n"
+              "fgetpos(in, 10);\n"
+              "fprintf(in, \"text\\n\");\n"
               "}\n");
-        ASSERT_EQUALS(std::string("[test.cpp:5]: (error) Resource leak: f\n"), errout.str());
+        ASSERT_EQUALS(std::string("[test.cpp:22]: (error) Resource leak: f\n"), errout.str());
     }
 
     void pointer_to_pointer()