walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Fixed #3355 (False positive: member variable initialization (::ZeroMemory))

This commit is contained in:
Daniel Marjamäki 2011-11-30 21:28:16 +01:00
parent 1084e4bece
commit 323019c48f
2 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/checkclass.cpp
View File

@ -395,7 +395,10 @@ void CheckClass::initializeVarList(const Function &func, std::list<std::string>
else { else {
assignAllVar(usage); assignAllVar(usage);
} }
} else if (Token::Match(ftok, "%var% (") && ftok->str() != "if") { } else if (Token::Match(ftok, "::| %var% (") && ftok->str() != "if") {
if (ftok->str() == "::")
ftok = ftok->next();
// Passing "this" => assume that everything is initialized // Passing "this" => assume that everything is initialized
for (const Token *tok2 = ftok->next()->link(); tok2 && tok2 != ftok; tok2 = tok2->previous()) { for (const Token *tok2 = ftok->next()->link(); tok2 && tok2 != ftok; tok2 = tok2->previous()) {
if (tok2->str() == "this") { if (tok2->str() == "this") {

10
test/testclass.cpp
View File

@ -76,6 +76,7 @@ private:
TEST_CASE(uninitVarArray5); TEST_CASE(uninitVarArray5);
TEST_CASE(uninitVarArray6); TEST_CASE(uninitVarArray6);
TEST_CASE(uninitVarArray7); TEST_CASE(uninitVarArray7);
TEST_CASE(uninitVarArray8);
TEST_CASE(uninitVarArray2D); TEST_CASE(uninitVarArray2D);
TEST_CASE(uninitVarArray3D); TEST_CASE(uninitVarArray3D);
TEST_CASE(uninitVarStruct1); // ticket #2172 TEST_CASE(uninitVarStruct1); // ticket #2172
@ -2424,6 +2425,15 @@ private:
ASSERT_EQUALS("", errout.str()); ASSERT_EQUALS("", errout.str());
} }
void uninitVarArray8() {
checkUninitVar("class Foo {\n"
" char a[10];\n"
"public:\n"
" Foo() { ::ZeroMemory(a); }\n"
"}");
ASSERT_EQUALS("", errout.str());
}
void uninitVarArray2D() { void uninitVarArray2D() {
checkUninitVar("class John\n" checkUninitVar("class John\n"
"{\n" "{\n"