walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Fixed #6325: false negative: uninitialized variable usage (write, posix).

This commit is contained in:
orbitcowboy 2014-12-15 10:05:44 +01:00
parent 87a42cd0f6
commit 32cd7d727d
2 changed files with 62 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
cfg/posix.cfg
View File

@ -287,6 +287,7 @@
</arg> </arg>
<arg nr="2"> <arg nr="2">
<minsize type="argvalue" arg="3"/> <minsize type="argvalue" arg="3"/>
<not-uninit/>
</arg> </arg>
<arg nr="3"> <arg nr="3">
<not-uninit/> <not-uninit/>

61
test/testuninitvar.cpp
View File

@ -77,6 +77,8 @@ private:
// dead pointer // dead pointer
TEST_CASE(deadPointer); TEST_CASE(deadPointer);
TEST_CASE(uninitvar_posix_write);
} }
void checkUninitVar(const char code[], const char filename[] = "test.cpp") { void checkUninitVar(const char code[], const char filename[] = "test.cpp") {
@ -3873,6 +3875,65 @@ private:
"}"); "}");
ASSERT_EQUALS("", errout.str()); ASSERT_EQUALS("", errout.str());
} }
void uninitvar_posix_write() { // #6325
// Load posix library file
LOAD_LIB_2(settings.library, "posix.cfg");
// check the first parameter of write
checkUninitVar("void uninitvar(char *buf)\n"
"{\n"
" int fd;\n"
" write(fd, buf, sizeof(buf));\n"
"}");
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: fd\n", errout.str());
checkUninitVar("void no_uninitvar(int fd, char *buf)\n"
"{\n"
" write(fd, buf, sizeof(buf));\n"
"}");
ASSERT_EQUALS("", errout.str());
// check the second parameter of the posix function write
checkUninitVar("void uninitvar() {\n"
" char *buf;\n"
" write(STDOUT_FILENO, buf, sizeof(buf));\n"
"}");
ASSERT_EQUALS("[test.cpp:3]: (error) Uninitialized variable: buf\n", errout.str());
checkUninitVar("void uninitvar() {\n"
" char buf[2];\n"
" write(STDOUT_FILENO, buf, 2);\n"
"}");
ASSERT_EQUALS("[test.cpp:3]: (error) Uninitialized variable: buf\n", errout.str());
// avoid false positives
checkUninitVar("void no_uninitvar(char *buf) {\n"
" write(STDOUT_FILENO, buf, sizeof(buf));\n"
"}");
ASSERT_EQUALS("", errout.str());
checkUninitVar("void no_uninitvar() {\n"
" char buf[1] = {'c'};\n"
" write(STDOUT_FILENO, &buf, 1);\n"
"}");
ASSERT_EQUALS("", errout.str());
// check the third parameter of the posix function write
checkUninitVar("void uninitvar(char *buf) {\n"
" int nbytes;\n"
" write(STDOUT_FILENO, buf, nbytes);\n"
"}");
TODO_ASSERT_EQUALS("[test.cpp:3]: (error) Uninitialized variable: nbytes\n", "", errout.str());
checkUninitVar("void no_uninitvar(char *buf, int nbytes)\n"
"{\n"
" write(STDOUT_FILENO, buf, nbytes);\n"
"}");
ASSERT_EQUALS("", errout.str());
}
}; };
REGISTER_TEST(TestUninitVar) REGISTER_TEST(TestUninitVar)