walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

posix.cfg: Fix vsyslog() configuration (#2150) 

Add tests to make sure no false positives are reported.
Found the issue via daca@home
This commit is contained in:
Sebastian 2019-09-06 10:16:11 +02:00 committed by GitHub
parent 1c77661b7e
commit 32dad3f44a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
cfg/posix.cfg
View File

@ -2165,15 +2165,16 @@ The function 'mktemp' is considered to be dangerous due to race conditions and s
<!-- void vsyslog(int priority, const char *format, va_list ap); --> <!-- void vsyslog(int priority, const char *format, va_list ap); -->
<function name="vsyslog"> <function name="vsyslog">
<noreturn>false</noreturn> <noreturn>false</noreturn>
<returnValue type="void"/>
<leak-ignore/> <leak-ignore/>
<arg nr="1" direction="in"> <arg nr="1" direction="in">
<not-uninit/> <not-uninit/>
</arg> </arg>
<formatstr/>
<arg nr="2" direction="in"> <arg nr="2" direction="in">
<not-uninit/>
<formatstr/> <formatstr/>
</arg> </arg>
<arg nr="any"> <arg nr="3" direction="in">
<not-uninit/> <not-uninit/>
</arg> </arg>
</function> </function>

8
test/cfg/posix.c
View File

@ -20,6 +20,8 @@
#include <time.h> #include <time.h>
#include <unistd.h> #include <unistd.h>
#include <pthread.h> #include <pthread.h>
#include <syslog.h>
#include <stdarg.h>
void memleak_scandir(void) void memleak_scandir(void)
{ {
@ -53,11 +55,15 @@ void no_memleak_scandir(void)
free(namelist); free(namelist);
} }
void validCode() void validCode(va_list valist_arg1, va_list valist_arg2)
{ {
void *ptr; void *ptr;
if (posix_memalign(&ptr, sizeof(void *), sizeof(void *)) == 0) if (posix_memalign(&ptr, sizeof(void *), sizeof(void *)) == 0)
free(ptr); free(ptr);
syslog(LOG_ERR, "err %u", 0U);
syslog(LOG_WARNING, "warn %d %d", 5, 1);
vsyslog(LOG_EMERG, "emerg %d", valist_arg1);
vsyslog(LOG_INFO, "test %s %d %p", valist_arg2);
} }
void bufferAccessOutOfBounds(int fd) void bufferAccessOutOfBounds(int fd)