walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

CheckOther::invalidPointerCast: Incorrect interpretation of settings

This commit is contained in:
Dmitry-Me 2014-11-14 20:22:17 +01:00 committed by Daniel Marjamäki
parent bba968f766
commit 353b885948
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/checkother.cpp
View File

@ -422,7 +422,7 @@ static std::string analyzeType(const Token* tok)
void CheckOther::invalidPointerCast()
{
if (!_settings->isEnabled("warning") && !_settings->isEnabled("portability"))
if (!_settings->isEnabled("portability"))
return;
const SymbolDatabase* const symbolDatabase = _tokenizer->getSymbolDatabase();
@ -481,7 +481,7 @@ void CheckOther::invalidPointerCast()
std::string fromType = analyzeType(fromTok);
std::string toType = analyzeType(toTok);
if (fromType != toType && !fromType.empty() && !toType.empty() && _settings->isEnabled("portability") && (toTok->str() != "char" || _settings->inconclusive))
if (fromType != toType && !fromType.empty() && !toType.empty() && (toTok->str() != "char" || _settings->inconclusive))
invalidPointerCastError(tok, fromType, toType, toTok->str() == "char");
}
}