walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Fixed ticket #524 (Containers range check shouldn't stop at first founded error) 

http://sourceforge.net/apps/trac/cppcheck/ticket/524
This commit is contained in:
Slava Semushin 2009-07-29 03:55:23 +07:00
parent 9bf80cb53b
commit 367efe31ea
2 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/checkstl.cpp
View File

@ -399,7 +399,6 @@ void CheckStl::stlBoundries()
else if (Token::Match(tok2, "%varid% <", iteratorid))
{
stlBoundriesError(tok2, container_name);
break;
}
}
}

15
test/teststl.cpp
View File

@ -59,6 +59,7 @@ private:
TEST_CASE(invalidcode);
TEST_CASE(stlBoundries1);
TEST_CASE(stlBoundries2);
}
void check(const char code[])
@ -396,6 +397,20 @@ private:
}
}
void stlBoundries2()
{
const std::string checkStr("void f()\n"
"{\n"
" std::vector<std::string> files;\n"
" std::vector<std::string>::const_iterator it;\n"
" for (it = files.begin(); it < files.end(); it++) { }\n"
" for (it = files.begin(); it < files.end(); it++) { };\n"
"}\n");
check(checkStr.c_str());
ASSERT_EQUALS("[test.cpp:5]: (error) vector range check should use != and not < since the order of the pointers isn't guaranteed\n[test.cpp:6]: (error) vector range check should use != and not < since the order of the pointers isn't guaranteed\n", errout.str());
}
};