walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Address compiler warning

This commit is contained in:
amai2012 2018-12-19 14:39:04 +01:00
parent 34874dd94f
commit 378ffed37e
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/mathlib.cpp
View File

@ -813,9 +813,10 @@ bool MathLib::isIntHex(const std::string& str)
state = DIGIT; state = DIGIT;
else else
return false; return false;
break;
case DIGIT: case DIGIT:
if (isxdigit(static_cast<unsigned char>(*it))) if (isxdigit(static_cast<unsigned char>(*it)))
; // state = DIGITS; ; // state = DIGIT;
else else
return isValidIntegerSuffix(it,str.end()); return isValidIntegerSuffix(it,str.end());
break; break;

1
test/testmathlib.cpp
View File

@ -668,6 +668,7 @@ private:
ASSERT_EQUALS(false, MathLib::isIntHex("+0x")); ASSERT_EQUALS(false, MathLib::isIntHex("+0x"));
ASSERT_EQUALS(false, MathLib::isIntHex("-0x")); ASSERT_EQUALS(false, MathLib::isIntHex("-0x"));
ASSERT_EQUALS(false, MathLib::isIntHex("0x")); ASSERT_EQUALS(false, MathLib::isIntHex("0x"));
ASSERT_EQUALS(false, MathLib::isIntHex("0xl"));
ASSERT_EQUALS(false, MathLib::isIntHex("0xx")); ASSERT_EQUALS(false, MathLib::isIntHex("0xx"));
ASSERT_EQUALS(false, MathLib::isIntHex("-0175")); ASSERT_EQUALS(false, MathLib::isIntHex("-0175"));
ASSERT_EQUALS(false, MathLib::isIntHex("-0_garbage_")); ASSERT_EQUALS(false, MathLib::isIntHex("-0_garbage_"));