walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

memsetZeroBytes: improved error message. ticket: #2421

This commit is contained in:
Daniel Marjamäki 2011-01-06 16:27:22 +01:00
parent 77ed6ecb5d
commit 37b1f7c296
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/checkother.cpp
View File

@ -2819,7 +2819,7 @@ void CheckOther::catchExceptionByValueError(const Token *tok)
void CheckOther::memsetZeroBytesError(const Token *tok, const std::string &varname) void CheckOther::memsetZeroBytesError(const Token *tok, const std::string &varname)
{ {
reportError(tok, Severity::warning, const std::string summary("memset() called to fill 0 bytes of \'" + varname + "\'");
"memsetZeroBytes", "memset() called to fill 0 bytes of \"" + varname + "\"" const std::string verbose(summary + ". Second and third arguments might be inverted.");
". Second and third arguments might be inverted."); reportError(tok, Severity::warning, "memsetZeroBytes", summary + "\n" + verbose);
} }

3
test/testother.cpp
View File

@ -1625,7 +1625,7 @@ private:
"}\n" "}\n"
); );
ASSERT_EQUALS("[test.cpp:2]: (warning) memset() called to fill 0" ASSERT_EQUALS("[test.cpp:2]: (warning) memset() called to fill 0"
" bytes of \"p\". Second and third arguments might be inverted.\n", errout.str()); " bytes of \'p\'\n", errout.str());
check("void f() {\n" check("void f() {\n"
" memset(p, sizeof(p), 0)\n" " memset(p, sizeof(p), 0)\n"
@ -1633,6 +1633,7 @@ private:
); );
TODO_ASSERT_EQUALS("[test.cpp:2]: (warning) memset() called to fill 0" TODO_ASSERT_EQUALS("[test.cpp:2]: (warning) memset() called to fill 0"
" bytes of \"p\". Second and third arguments might be inverted.\n", errout.str()); " bytes of \"p\". Second and third arguments might be inverted.\n", errout.str());
ASSERT_EQUALS("", errout.str());
} }
}; };