walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Added todo comments to fix false negatives caused by my fix for #3128

This commit is contained in:
Daniel Marjamäki 2011-10-08 07:39:20 +02:00
parent e2ec5a127f
commit 37d4a01dcb
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/checknullpointer.cpp
View File

@ -370,6 +370,9 @@ void CheckNullPointer::nullPointerStructByDeRefAndChec()
else if (Token::Match(tok1, "( ! %var% ||") || else if (Token::Match(tok1, "( ! %var% ||") ||
Token::Match(tok1, "( %var% &&")) Token::Match(tok1, "( %var% &&"))
{ {
// TODO: there are false negatives caused by this. The
// variable should be removed from skipvar after the
// condition
tok1 = tok1->next(); tok1 = tok1->next();
if (tok1->str() == "!") if (tok1->str() == "!")
tok1 = tok1->next(); tok1 = tok1->next();
@ -573,6 +576,9 @@ void CheckNullPointer::nullPointerByDeRefAndChec()
if (Token::Match(tok1->link()->previous(), "while ( %varid%", varid)) if (Token::Match(tok1->link()->previous(), "while ( %varid%", varid))
break; break;
// TODO: there might be false negatives. perhaps
// instead of bailing out it's ok to skip the condition.
// this bailout is related to #3128
if (Token::Match(tok1->link(), "( ! %varid% ||", varid) || if (Token::Match(tok1->link(), "( ! %varid% ||", varid) ||
Token::Match(tok1->link(), "( %varid% &&", varid)) Token::Match(tok1->link(), "( %varid% &&", varid))
break; break;