walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

errmsg: Moved 'function parameter parname is passed by value' to the style checks

This commit is contained in:
Daniel Marjamäki 2009-01-26 18:32:00 +00:00
parent 068b1458c2
commit 3d61334a8c
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/cppcheck.cpp
View File

@ -389,7 +389,7 @@ void CppCheck::checkFile(const std::string &code, const char FileName[])
checkOther.CheckStructMemberUsage(); checkOther.CheckStructMemberUsage();
// Check if a constant function parameter is passed by value // Check if a constant function parameter is passed by value
if (ErrorMessage::passedByValue()) if (ErrorMessage::passedByValue(_settings))
checkOther.CheckConstantFunctionParameter(); checkOther.CheckConstantFunctionParameter();
// Variable scope (check if the scope could be limited) // Variable scope (check if the scope could be limited)

4
src/errormessage.h
View File

@ -251,9 +251,9 @@ public:
{ {
return msg1(tokenizer, Location) + "Function parameter '" + parname + "' is passed by value. It could be passed by reference instead."; return msg1(tokenizer, Location) + "Function parameter '" + parname + "' is passed by value. It could be passed by reference instead.";
} }
static bool passedByValue() static bool passedByValue(const Settings &s)
{ {
return true; return s._checkCodingStyle;
} }
static std::string constStatement(const Tokenizer *tokenizer, const Token *Location, const std::string &type) static std::string constStatement(const Tokenizer *tokenizer, const Token *Location, const std::string &type)

2
tools/errmsg.cpp
View File

@ -86,7 +86,7 @@ int main()
err.push_back(Message("udivError", Message::always, "Unsigned division. The result will be wrong.")); err.push_back(Message("udivError", Message::always, "Unsigned division. The result will be wrong."));
err.push_back(Message("udivWarning", Message::style_all, "Warning: Division with signed and unsigned operators")); err.push_back(Message("udivWarning", Message::style_all, "Warning: Division with signed and unsigned operators"));
err.push_back(Message("unusedStructMember", Message::style, "struct or union member '%1::%2' is never used", "structname", "varname")); err.push_back(Message("unusedStructMember", Message::style, "struct or union member '%1::%2' is never used", "structname", "varname"));
err.push_back(Message("passedByValue", Message::always, "Function parameter '%1' is passed by value. It could be passed by reference instead.", "parname")); err.push_back(Message("passedByValue", Message::style, "Function parameter '%1' is passed by value. It could be passed by reference instead.", "parname"));
err.push_back(Message("constStatement", Message::style, "Redundant code: Found a statement that begins with %1 constant", "type")); err.push_back(Message("constStatement", Message::style, "Redundant code: Found a statement that begins with %1 constant", "type"));
err.push_back(Message("charArrayIndex", Message::style, "Warning - using char variable as array index")); err.push_back(Message("charArrayIndex", Message::style, "Warning - using char variable as array index"));
err.push_back(Message("charBitOp", Message::style, "Warning - using char variable in bit operation")); err.push_back(Message("charBitOp", Message::style, "Warning - using char variable in bit operation"));