From 3f069d9e445b962599607fd23f0b86ba12012e73 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Marjam=C3=A4ki?= Date: Sun, 23 Apr 2017 15:34:45 +0200 Subject: [PATCH] Write two FIXME comments, create library configuration to replace hardcoded checks --- lib/checkfunctions.cpp | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/lib/checkfunctions.cpp b/lib/checkfunctions.cpp index e7adddcde..de211008a 100644 --- a/lib/checkfunctions.cpp +++ b/lib/checkfunctions.cpp @@ -292,6 +292,13 @@ void CheckFunctions::mathfunctionCallWarning(const Token *tok, const std::string //--------------------------------------------------------------------------- void CheckFunctions::memsetZeroBytes() { +// FIXME: +// Replace this with library configuration. +// For instance: +// +// +// + if (!_settings->isEnabled(Settings::WARNING)) return; @@ -320,6 +327,14 @@ void CheckFunctions::memsetZeroBytesError(const Token *tok) void CheckFunctions::memsetInvalid2ndParam() { +// FIXME: +// Replace this with library configuration. +// For instance: +// +// +// +// + const bool printPortability = _settings->isEnabled(Settings::PORTABILITY); const bool printWarning = _settings->isEnabled(Settings::WARNING); if (!printWarning && !printPortability)