cleaned up includes based on include-what-you-use (#4007)

* cleaned up includes based on include-what-you-use

* updated translations

cli/filelister.cpp

@@ -18,6 +18,7 @@
 
 #include "filelister.h"
 
+#include "config.h"
 #include "path.h"
 #include "pathmatch.h"
 #include "utils.h"

gui/aboutdialog.h

@@ -22,6 +22,7 @@
 #include <QDialog>
 #include <QString>
 
+class QObject;
 class QWidget;
 namespace Ui {
     class About;

gui/applicationdialog.h

@@ -22,6 +22,7 @@
 #include <QDialog>
 #include <QString>
 
+class QObject;
 class QWidget;
 class Application;
 namespace Ui {

gui/checkthread.cpp

@@ -18,11 +18,25 @@
 
 #include "checkthread.h"
 
+#include "analyzerinfo.h"
 #include "common.h"
 #include "cppcheck.h"
 #include "erroritem.h"
+#include "errorlogger.h"
+#include "errortypes.h"
+#include "settings.h"
+#include "standards.h"
 #include "threadresult.h"
 
+#include <cstddef>
+#include <functional>
+#include <list>
+#include <map>
+#include <ostream>
+#include <set>
+#include <string>
+#include <vector>
+
 #include <QDebug>
 #include <QDir>
 #include <QFile>

gui/checkthread.h

@@ -25,6 +25,7 @@
 
 #include <QThread>
 
+class QObject;
 class Settings;
 class ThreadResult;
 

gui/codeeditor.cpp

@@ -23,6 +23,8 @@
 #include <QPainter>
 #include <QShortcut>
 
+class QTextDocument;
+
 
 Highlighter::Highlighter(QTextDocument *parent,
                          CodeEditorStyle *widgetStyle) :

gui/codeeditor.h

@@ -24,8 +24,11 @@
 #include <QSyntaxHighlighter>
 
 class CodeEditorStyle;
+class QObject;
 class QPaintEvent;
+class QRect;
 class QResizeEvent;
+class QTextDocument;
 
 class Highlighter : public QSyntaxHighlighter {
     Q_OBJECT

gui/codeeditstylecontrols.cpp

@@ -20,6 +20,8 @@
 
 #include <QColorDialog>
 
+class QWidget;
+
 SelectColorButton::SelectColorButton(QWidget* parent) :
     QPushButton(parent),
     mColor(QColor(255, 255, 255))

gui/codeeditstylecontrols.h

@@ -27,6 +27,9 @@
 #include <QFont>
 #include <QPushButton>
 
+class QObject;
+class QWidget;
+
 class SelectColorButton : public QPushButton {
     Q_OBJECT
 public:

gui/codeeditstyledialog.cpp

@@ -24,6 +24,8 @@
 #include <QDialogButtonBox>
 #include <QFormLayout>
 
+class QWidget;
+
 const QString StyleEditDialog::mSampleDocument(
     "/*****\n"
     "* Multiline Comment\n"

gui/codeeditstyledialog.h

@@ -26,7 +26,10 @@
 class CodeEditor;
 class SelectColorButton;
 class SelectFontWeightCombo;
+class QObject;
 class QPushButton;
+class QStringList;
+class QWidget;
 
 class StyleEditDialog : public QDialog {
     Q_OBJECT

gui/csvreport.h

@@ -24,6 +24,8 @@
 #include <QString>
 #include <QTextStream>
 
+class ErrorItem;
+
 /// @addtogroup GUI
 /// @{
 

gui/erroritem.cpp

@@ -20,6 +20,8 @@
 
 #include "common.h"
 
+#include <list>
+
 QErrorPathItem::QErrorPathItem(const ErrorMessage::FileLocation &loc)
     : file(QString::fromStdString(loc.getfile(false)))
     , line(loc.line)

gui/filelist.cpp

@@ -20,6 +20,10 @@
 
 #include "pathmatch.h"
 
+#include <algorithm>
+#include <string>
+#include <vector>
+
 #include <QDir>
 
 QStringList FileList::getDefaultFilters()

gui/fileviewdialog.h

@@ -22,6 +22,7 @@
 #include <QDialog>
 #include <QString>
 
+class QObject;
 class QWidget;
 class QTextEdit;
 namespace Ui {

gui/helpdialog.cpp

@@ -28,6 +28,8 @@
 #include <QHelpIndexWidget>
 #include <QMessageBox>
 
+class QWidget;
+
 void HelpBrowser::setHelpEngine(QHelpEngine *helpEngine)
 {
     mHelpEngine = helpEngine;

gui/helpdialog.h

@@ -22,12 +22,14 @@
 #include <QDialog>
 #include <QTextBrowser>
 
+class QHelpEngine;
+class QObject;
+class QUrl;
+class QWidget;
 namespace Ui {
     class HelpDialog;
 }
 
-class QHelpEngine;
-
 class HelpBrowser : public QTextBrowser {
 public:
     HelpBrowser(QWidget* parent = nullptr) : QTextBrowser(parent), mHelpEngine(nullptr) {}

gui/libraryaddfunctiondialog.cpp

@@ -23,6 +23,8 @@
 #include <QRegularExpression>
 #include <QRegularExpressionValidator>
 
+class QWidget;
+
 LibraryAddFunctionDialog::LibraryAddFunctionDialog(QWidget *parent) :
     QDialog(parent),
     mUi(new Ui::LibraryAddFunctionDialog)

gui/libraryaddfunctiondialog.h

@@ -21,14 +21,16 @@
 
 #include <QDialog>
 
-#define SIMPLENAME     "[_a-zA-Z][_a-zA-Z0-9]*"            // just a name
+class QObject;
-#define SCOPENAME      SIMPLENAME "(::" SIMPLENAME ")*"    // names with optional scope
+class QWidget;
-#define NAMES          SCOPENAME "(," SCOPENAME ")*"       // names can be separated by comma
-
 namespace Ui {
     class LibraryAddFunctionDialog;
 }
 
+#define SIMPLENAME     "[_a-zA-Z][_a-zA-Z0-9]*"            // just a name
+#define SCOPENAME      SIMPLENAME "(::" SIMPLENAME ")*"    // names with optional scope
+#define NAMES          SCOPENAME "(," SCOPENAME ")*"       // names can be separated by comma
+
 class LibraryAddFunctionDialog : public QDialog {
     Q_OBJECT
 

gui/librarydialog.cpp

@@ -25,12 +25,16 @@
 
 #include "ui_librarydialog.h"
 
+#include <string>
+
 #include <QFile>
 #include <QFileDialog>
 #include <QMessageBox>
 #include <QRegularExpression>
 #include <QTextStream>
 
+class QWidget;
+
 // TODO: get/compare functions from header
 
 class FunctionListItem : public QListWidgetItem {

gui/librarydialog.h

@@ -24,7 +24,8 @@
 #include <QDialog>
 
 class QListWidgetItem;
-
+class QObject;
+class QWidget;
 namespace Ui {
     class LibraryDialog;
 }

gui/libraryeditargdialog.cpp

@@ -20,6 +20,8 @@
 
 #include "ui_libraryeditargdialog.h"
 
+class QWidget;
+
 LibraryEditArgDialog::LibraryEditArgDialog(QWidget *parent, const CppcheckLibraryData::Function::Arg &arg) :
     QDialog(parent),
     mUi(new Ui::LibraryEditArgDialog),

gui/libraryeditargdialog.h

@@ -23,6 +23,8 @@
 
 #include <QDialog>
 
+class QObject;
+class QWidget;
 namespace Ui {
     class LibraryEditArgDialog;
 }

gui/main.cpp

@@ -29,6 +29,7 @@
 #else
 #include <iostream>
 #endif
+#include <string>
 
 #include <QApplication>
 #include <QCoreApplication>

gui/mainwindow.cpp

@@ -20,25 +20,39 @@
 
 #include "applicationlist.h"
 #include "aboutdialog.h"
+#include "analyzerinfo.h"
 #include "common.h"
 #include "cppcheck.h"
+#include "errortypes.h"
 #include "filelist.h"
 #include "fileviewdialog.h"
 #include "helpdialog.h"
+#include "importproject.h"
 #include "librarydialog.h"
+#include "platform.h"
 #include "projectfile.h"
 #include "projectfiledialog.h"
 #include "report.h"
+#include "resultsview.h"
 #include "scratchpad.h"
 #include "showtypes.h"
 #include "statsdialog.h"
 #include "settingsdialog.h"
+#include "standards.h"
+#include "suppressions.h"
 #include "threadhandler.h"
 #include "threadresult.h"
 #include "translationhandler.h"
 
 #include "ui_mainwindow.h"
 
+#include <algorithm>
+#include <functional>
+#include <list>
+#include <set>
+#include <string>
+#include <vector>
+
 #include <QApplication>
 #include <QAction>
 #include <QActionGroup>

gui/mainwindow.h

@@ -19,6 +19,7 @@
 #ifndef MAINWINDOW_H
 #define MAINWINDOW_H
 
+#include "library.h"
 #include "settings.h"
 #include "platforms.h"
 
@@ -36,6 +37,9 @@ class QActionGroup;
 class QSettings;
 class QTimer;
 class QLineEdit;
+class ImportProject;
+class QCloseEvent;
+class QObject;
 namespace Ui {
     class MainWindow;
 }

gui/newsuppressiondialog.cpp

@@ -25,6 +25,11 @@
 
 #include "ui_newsuppressiondialog.h"
 
+#include <functional>
+#include <string>
+
+class QWidget;
+
 NewSuppressionDialog::NewSuppressionDialog(QWidget *parent) :
     QDialog(parent),
     mUI(new Ui::NewSuppressionDialog)

gui/newsuppressiondialog.h

@@ -23,6 +23,8 @@
 
 #include <QDialog>
 
+class QObject;
+class QWidget;
 namespace Ui {
     class NewSuppressionDialog;
 }

gui/printablereport.h

@@ -21,6 +21,8 @@
 
 #include "report.h"
 
+class ErrorItem;
+
 /// @addtogroup GUI
 /// @{
 

gui/projectfile.cpp

@@ -19,9 +19,13 @@
 #include "projectfile.h"
 
 #include "common.h"
+#include "config.h"
 #include "importproject.h"
 #include "settings.h"
 
+#include <string>
+#include <utility>
+
 #include <QFile>
 #include <QDir>
 #include <QXmlStreamReader>

gui/projectfile.h

@@ -22,6 +22,7 @@
 #include "settings.h"
 #include "suppressions.h"
 
+#include <cstddef>
 #include <map>
 
 #include <QObject>

gui/projectfiledialog.cpp

@@ -23,11 +23,16 @@
 #include "importproject.h"
 #include "library.h"
 #include "newsuppressiondialog.h"
+#include "platform.h"
 #include "platforms.h"
 #include "projectfile.h"
+#include "settings.h"
 
 #include "ui_projectfile.h"
 
+#include <list>
+#include <string>
+
 #include <QDir>
 #include <QFileDialog>
 #include <QFileInfo>
@@ -35,6 +40,8 @@
 #include <QRegularExpressionValidator>
 #include <QSettings>
 
+class QModelIndex;
+
 /** Return paths from QListWidget */
 static QStringList getPaths(const QListWidget *list)
 {

gui/projectfiledialog.h

@@ -25,6 +25,8 @@
 #include <QString>
 #include <QStringList>
 
+class QModelIndex;
+class QObject;
 class QWidget;
 namespace Ui {
     class ProjectFile;

gui/resultstree.cpp

@@ -26,9 +26,13 @@
 #include "projectfile.h"
 #include "report.h"
 #include "showtypes.h"
+#include "suppressions.h"
 #include "threadhandler.h"
 #include "xmlreportv2.h"
 
+#include <string>
+#include <utility>
+
 #include <QAction>
 #include <QApplication>
 #include <QClipboard>

gui/resultstree.h

@@ -35,6 +35,8 @@ class QWidget;
 class QItemSelectionModel;
 class ThreadHandler;
 class QContextMenuEvent;
+class QKeyEvent;
+class QObject;
 class QSettings;
 
 /// @addtogroup GUI

gui/resultsview.cpp

@@ -19,12 +19,14 @@
 #include "resultsview.h"
 
 #include "checkstatistics.h"
+#include "codeeditor.h"
 #include "codeeditorstyle.h"
 #include "common.h"
 #include "csvreport.h"
 #include "erroritem.h"
 #include "path.h"
 #include "printablereport.h"
+#include "resultstree.h"
 #include "txtreport.h"
 #include "xmlreport.h"
 #include "xmlreportv2.h"

gui/resultsview.h

@@ -34,7 +34,8 @@ class QModelIndex;
 class QPrinter;
 class QSettings;
 class CheckStatistics;
-class QListWidgetItem;
+class QObject;
+class QPoint;
 namespace Ui {
     class ResultsView;
 }

gui/scratchpad.cpp

@@ -18,6 +18,7 @@
 
 #include "scratchpad.h"
 
+#include "codeeditor.h"
 #include "mainwindow.h"
 
 #include "ui_scratchpad.h"

gui/scratchpad.h

@@ -22,6 +22,7 @@
 #include <QDialog>
 
 class MainWindow;
+class QObject;
 namespace Ui {
     class ScratchPad;
 }

gui/settingsdialog.cpp

@@ -18,6 +18,7 @@
 
 #include "settingsdialog.h"
 
+#include "application.h"
 #include "applicationdialog.h"
 #include "applicationlist.h"
 #include "codeeditorstyle.h"

gui/settingsdialog.h

@@ -28,6 +28,7 @@ class ApplicationList;
 class TranslationHandler;
 class CodeEditorStyle;
 class QCheckBox;
+class QObject;
 namespace Ui {
     class Settings;
 }

gui/statsdialog.cpp

@@ -21,6 +21,7 @@
 #include "checkstatistics.h"
 #include "common.h"
 #include "projectfile.h"
+#include "showtypes.h"
 
 #include "ui_statsdialog.h"
 

gui/statsdialog.h

@@ -23,6 +23,8 @@
 
 class ProjectFile;
 class CheckStatistics;
+class QObject;
+class QWidget;
 namespace Ui {
     class StatsDialog;
 }

gui/test/benchmark/simple/benchmarksimple.h

@@ -16,8 +16,11 @@
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
+#include "color.h"
 #include "errorlogger.h"
 
+#include <string>
+
 #include <QObject>
 
 class BenchmarkSimple : public QObject, public ErrorLogger {

gui/threadhandler.cpp

@@ -23,6 +23,10 @@
 #include "resultsview.h"
 #include "settings.h"
 
+#include <list>
+#include <string>
+#include <utility>
+
 #include <QDebug>
 #include <QFileInfo>
 #include <QSettings>

gui/threadhandler.h

@@ -35,6 +35,7 @@ class CheckThread;
 class QSettings;
 class Settings;
 class ImportProject;
+class ErrorItem;
 
 /// @addtogroup GUI
 /// @{

gui/threadresult.cpp

@@ -21,6 +21,7 @@
 #include "common.h"
 #include "erroritem.h"
 #include "errorlogger.h"
+#include "errortypes.h"
 
 #include <QFile>
 

gui/threadresult.h

@@ -24,6 +24,9 @@
 #include "errorlogger.h"
 #include "importproject.h"
 
+#include <list>
+#include <string>
+
 #include <QMutex>
 #include <QObject>
 #include <QStringList>

gui/txtreport.h

@@ -24,6 +24,9 @@
 #include <QString>
 #include <QTextStream>
 
+class ErrorItem;
+class QObject;
+
 /// @addtogroup GUI
 /// @{
 

gui/xmlreportv2.h

@@ -19,6 +19,7 @@
 #ifndef XML_REPORTV2_H
 #define XML_REPORTV2_H
 
+#include "erroritem.h"
 #include "xmlreport.h"
 
 #include <QString>

lib/astutils.h

@@ -32,11 +32,9 @@
 #include "errortypes.h"
 #include "symboldatabase.h"
 
-class Function;
 class Library;
 class Settings;
 class Token;
-class Variable;
 
 enum class ChildrenToVisit {
     none,

lib/checkautovariables.cpp

@@ -30,7 +30,6 @@
 #include "tokenize.h"
 #include "valueflow.h"
 
-#include <algorithm>
 #include <list>
 #include <unordered_set>
 #include <utility>

lib/checkclass.h

@@ -36,10 +36,6 @@
 class ErrorLogger;
 class Settings;
 class Token;
-class Function;
-class Scope;
-class Type;
-class Variable;
 
 namespace CTU {
     class FileInfo;

lib/checkother.cpp

@@ -40,7 +40,6 @@
 #include <memory>
 #include <ostream>
 #include <set>
-#include <type_traits>
 #include <utility>
 #include <numeric>
 

lib/checkunusedvar.cpp

@@ -33,7 +33,6 @@
 
 #include <algorithm>
 #include <list>
-#include <memory>
 #include <set>
 #include <utility>
 #include <vector>

lib/library.cpp

@@ -34,6 +34,7 @@
 #include <iosfwd>
 #include <list>
 #include <memory>
+#include <stack>
 #include <string>
 
 #include <tinyxml2.h>

lib/library.h

@@ -36,7 +36,6 @@
 #include <vector>
 
 class Token;
-class TokenList;
 class Settings;
 
 namespace tinyxml2 {

lib/programmemory.cpp

@@ -36,7 +36,6 @@
 #include <list>
 #include <memory>
 #include <string>
-#include <type_traits>
 #include <utility>
 #include <vector>
 

lib/programmemory.h

@@ -26,6 +26,7 @@
 #include <cstddef>
 #include <functional>
 #include <map>
+#include <string>
 #include <unordered_map>
 
 class Token;

lib/settings.h

@@ -34,7 +34,6 @@
 #include <atomic>
 #include <cstdint>
 #include <list>
-#include <map>
 #include <set>
 #include <string>
 #include <vector>

lib/suppressions.cpp

@@ -22,7 +22,9 @@
 #include "mathlib.h"
 #include "path.h"
 #include "utils.h"
+#include "token.h"
 #include "tokenize.h"
+#include "tokenlist.h"
 
 #include <algorithm>
 #include <cctype>   // std::isdigit, std::isalnum, etc

lib/symboldatabase.h

@@ -33,6 +33,7 @@
 #include <memory>
 #include <set>
 #include <string>
+#include <type_traits>
 #include <utility>
 #include <vector>
 

lib/templatesimplifier.cpp

@@ -33,7 +33,6 @@
 #include <map>
 #include <memory>
 #include <stack>
-#include <type_traits>
 #include <utility>
 
 static Token *skipRequires(Token *tok)

lib/valueflow.cpp

@@ -115,7 +115,6 @@
 #include <map>
 #include <memory>
 #include <set>
-#include <stack>
 #include <string>
 #include <type_traits>
 #include <unordered_map>

test/testsymboldatabase.cpp

@@ -26,6 +26,7 @@
 #include "tokenize.h"
 #include "tokenlist.h"
 
+#include <algorithm>
 #include <cstdint>
 #include <cstring>
 #include <limits>

test/testthreadexecutor.cpp

@@ -21,11 +21,13 @@
 #include "testutils.h"
 #include "threadexecutor.h"
 
+#include <algorithm>
 #include <cstddef>
 #include <map>
 #include <ostream>
 #include <string>
 #include <utility>
+#include <vector>
 
 class TestThreadExecutor : public TestFixture {
 public:

test/testutils.h

@@ -29,6 +29,7 @@
 #include <cstdio>
 #include <iosfwd>
 #include <list>
+#include <ostream>
 #include <string>
 
 class Token;