walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

misra: Fix 8.2 false positives (#3306) 

Type declaration on the next line is not allowed in rule 8.2. But we
need to make sure that the files of the checked files are the same.

Reported on the forum: https://sourceforge.net/p/cppcheck/discussion/development/thread/801dc07e59/#32c3/e90b/293e/39df/85b3/b821/e0c3
This commit is contained in:
Georgiy Komarov 2021-06-25 17:06:29 +03:00 committed by GitHub
parent a45e0776f2
commit 452c92494e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
addons/misra.py
View File

@ -1512,7 +1512,9 @@ class MisraChecker:
self.reportError(typeStartToken, 8, 2) self.reportError(typeStartToken, 8, 2)
# Type declaration on next line (old style declaration list) is not allowed # Type declaration on next line (old style declaration list) is not allowed
if (typeStartToken.linenr > endCall.linenr) or (typeStartToken.column > endCall.column): if ((typeStartToken.file == endCall.file) and
((typeStartToken.linenr > endCall.linenr) or
(typeStartToken.column > endCall.column))):
self.reportError(typeStartToken, 8, 2) self.reportError(typeStartToken, 8, 2)
# Check arguments in pointer declarations # Check arguments in pointer declarations

4
addons/test/misra/misra-test.c
View File

@ -322,6 +322,10 @@ static int misra_8_2_l ( // 8.2
int16_t ( *misra_8_2_p_a ) (); // 8.2 int16_t ( *misra_8_2_p_a ) (); // 8.2
int16_t ( *misra_8_2_p_b ) (void); int16_t ( *misra_8_2_p_b ) (void);
int16_t ( *misra_8_2_p_c ) (int); int16_t ( *misra_8_2_p_c ) (int);
int misra_8_2_no_fp (int a)
{
return a + 42;
}
extern int a811[]; // 8.11 extern int a811[]; // 8.11

1
addons/test/misra/misra-test.h
View File

@ -3,4 +3,5 @@
struct misra_h_s { int foo; }; struct misra_h_s { int foo; };
bool test(char *); // 8.2 bool test(char *); // 8.2
bool test(char *a); // OK bool test(char *a); // OK
int misra_8_2_no_fp(int a);
#endif // MISRA_TEST_H #endif // MISRA_TEST_H