walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Fixed #7121 (False positive 'Uninitialized variable' converting pointer to reference)

This commit is contained in:
Daniel Marjamäki 2015-11-10 10:18:24 +01:00
parent 5cd36d6f8a
commit 459a4e0cbe
2 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/checkuninitvar.cpp
View File

@ -796,6 +796,9 @@ bool CheckUninitVar::isVariableUsage(const Token *vartok, bool pointer, Alloc al
} }
if (Token::Match(vartok->previous(), "++|--|%cop%")) { if (Token::Match(vartok->previous(), "++|--|%cop%")) {
if (_tokenizer->isCPP() && alloc == ARRAY && Token::Match(vartok->tokAt(-4), "& %var% =|( *"))
return false;
if (_tokenizer->isCPP() && Token::Match(vartok->previous(), ">>|<<")) { if (_tokenizer->isCPP() && Token::Match(vartok->previous(), ">>|<<")) {
const Token* tok2 = vartok->previous(); const Token* tok2 = vartok->previous();
if (Token::simpleMatch(tok2->astOperand1(), ">>")) if (Token::simpleMatch(tok2->astOperand1(), ">>"))

12
test/testuninitvar.cpp
View File

@ -2743,6 +2743,12 @@ private:
TODO_ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: x\n", TODO_ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: x\n",
"", errout.str()); "", errout.str());
checkUninitVar("void f() {\n"
" int x[10];\n"
" int &x0(*x);\n"
"}");
ASSERT_EQUALS("", errout.str());
// .... // ....
checkUninitVar("struct ABC { int a; };\n" // struct initialization checkUninitVar("struct ABC { int a; };\n" // struct initialization
"void clear(struct ABC &abc);\n" "void clear(struct ABC &abc);\n"
@ -3581,12 +3587,6 @@ private:
"}"); "}");
ASSERT_EQUALS("", errout.str()); ASSERT_EQUALS("", errout.str());
checkUninitVar("void f() {\n"
" char *s = malloc(100);\n"
" *s = x;\n"
"}");
ASSERT_EQUALS("", errout.str());
checkUninitVar("void f() {\n" checkUninitVar("void f() {\n"
" char *p = malloc(100);\n" " char *p = malloc(100);\n"
" p || assert_failed();\n" " p || assert_failed();\n"