From 45b4580554f0fb99c4ef79bf2fb855885a3332cc Mon Sep 17 00:00:00 2001
From: Paul Fultz II <pfultz2@yahoo.com>
Date: Sun, 10 Apr 2022 15:47:58 -0500
Subject: [PATCH] Fix 10957: Crash on valid code (#3991)

---
 lib/valueflow.cpp      | 3 +++
 test/testvalueflow.cpp | 3 +++
 2 files changed, 6 insertions(+)

diff --git a/lib/valueflow.cpp b/lib/valueflow.cpp
index 7767dcd14..315802109 100644
--- a/lib/valueflow.cpp
+++ b/lib/valueflow.cpp
@@ -5736,6 +5736,9 @@ struct ConditionHandler {
                     std::swap(thenValues, elseValues);
             }
 
+            if (!condTop)
+                return;
+
             if (Token::simpleMatch(condTop, "?")) {
                 Token* colon = condTop->astOperand2();
                 forward(colon->astOperand1(), cond.vartok, thenValues, tokenlist, settings);
diff --git a/test/testvalueflow.cpp b/test/testvalueflow.cpp
index 70aa168ad..fc646b711 100644
--- a/test/testvalueflow.cpp
+++ b/test/testvalueflow.cpp
@@ -6442,6 +6442,9 @@ private:
                "    void f(std::array<T*, 2>& a);\n"
                "};\n";
         valueOfTok(code, "a");
+
+        code = "void f(const char * const x) { !!system(x); }\n";
+        valueOfTok(code, "x");
     }
 
     void valueFlowHang() {