walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

GUI: Properly refresh result tree if new rows are added (#4727)

This commit is contained in:
PKEuS 2015-10-14 17:44:52 +02:00
parent d0cc97a4cf
commit 46a43f3041
2 changed files with 5 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
gui/resultstree.cpp
View File

@ -105,7 +105,6 @@ bool ResultsTree::AddErrorItem(const ErrorItem &item)
} }
bool hide = !mShowSeverities.isShown(item.severity); bool hide = !mShowSeverities.isShown(item.severity);
//bool hide = !mShowTypes[SeverityToShowType(item.severity)];
//If specified, filter on summary, message, filename, and id //If specified, filter on summary, message, filename, and id
if (!hide && !mFilter.isEmpty()) { if (!hide && !mFilter.isEmpty()) {
@ -132,7 +131,8 @@ bool ResultsTree::AddErrorItem(const ErrorItem &item)
line.severity = item.severity; line.severity = item.severity;
//Create the base item for the error and ensure it has a proper //Create the base item for the error and ensure it has a proper
//file item as a parent //file item as a parent
QStandardItem *stditem = AddBacktraceFiles(EnsureFileItem(item.files[0], item.file0, hide), QStandardItem* fileItem = EnsureFileItem(item.files[0], item.file0, hide);
QStandardItem* stditem = AddBacktraceFiles(fileItem,
line, line,
hide, hide,
SeverityToIcon(line.severity)); SeverityToIcon(line.severity));
@ -175,10 +175,10 @@ bool ResultsTree::AddErrorItem(const ErrorItem &item)
child_item->setData(QVariant(child_data)); child_item->setData(QVariant(child_data));
} }
//TODO just hide/show current error and it's file // Partially refresh the tree: Unhide error item and file item if necessary
//since this does a lot of unnecessary work
if (!hide) { if (!hide) {
ShowFileItem(realfile); setRowHidden(stditem->row(), stditem->index(), false);
setRowHidden(fileItem->row(), QModelIndex(), false);
} }
return true; return true;
} }
@ -470,14 +470,6 @@ QStandardItem *ResultsTree::EnsureFileItem(const QString &fullpath, const QStrin
return item; return item;
} }
void ResultsTree::ShowFileItem(const QString &name)
{
QStandardItem *item = FindFileItem(name);
if (item) {
setRowHidden(0, mModel.indexFromItem(item), false);
}
}
void ResultsTree::contextMenuEvent(QContextMenuEvent * e) void ResultsTree::contextMenuEvent(QContextMenuEvent * e)
{ {
QModelIndex index = indexAt(e->pos()); QModelIndex index = indexAt(e->pos());

7
gui/resultstree.h
View File

@ -386,13 +386,6 @@ protected:
*/ */
QStandardItem *EnsureFileItem(const QString &fullpath, const QString &file0, bool hide); QStandardItem *EnsureFileItem(const QString &fullpath, const QString &file0, bool hide);
/**
* @brief Show a file item
*
* @param name Filename of the fileitem
*/
void ShowFileItem(const QString &name);
/** /**
* @brief Item model for tree * @brief Item model for tree
* *