walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Uninitialized variables: Fixed false negatives when calling unknown function with uninitialized variable by value: 'f(a+1)'

This commit is contained in:
Daniel Marjamäki 2010-11-13 15:10:17 +01:00
parent 6836198a5c
commit 47d37e7a05
2 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/checkuninitvar.cpp
View File

@ -677,7 +677,7 @@ private:
} }
// it is possible that the variable is initialized here // it is possible that the variable is initialized here
if (Token::Match(tok2->previous(), "[(,] %var% [+-,)]")) if (Token::Match(tok2->previous(), "[(,] %var% [,)]"))
bailouts.insert(tok2->varId()); bailouts.insert(tok2->varId());
// array initialization.. // array initialization..
@ -689,7 +689,7 @@ private:
if ((*it)->varId == tok2->varId()) if ((*it)->varId == tok2->varId())
{ {
const UninitVar *c = dynamic_cast<const UninitVar *>(*it); const UninitVar *c = dynamic_cast<const UninitVar *>(*it);
if (c && c->array) if (c && (c->array || (c->pointer && c->alloc)))
bailouts.insert(tok2->varId()); bailouts.insert(tok2->varId());
break; break;
} }

7
test/testuninitvar.cpp
View File

@ -1178,6 +1178,13 @@ private:
"}\n"); "}\n");
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: f\n", errout.str()); ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: f\n", errout.str());
checkUninitVar("void f()\n"
"{\n"
" int i;\n"
" x(i+2);\n"
"}\n");
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: i\n", errout.str());
checkUninitVar("void f()\n" checkUninitVar("void f()\n"
"{\n" "{\n"
" char *p = malloc(10);\n" " char *p = malloc(10);\n"