walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

CheckBufferOverrun: Improved checking for types other than char

This commit is contained in:
Daniel Marjamäki 2007-05-26 06:41:41 +00:00
parent da2dc8cc5b
commit 48a584201c
1 changed files with 32 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
CheckBufferOverrun.cpp
View File

@ -33,6 +33,13 @@ void CheckBufferOverrun()
{ {
const char *varname = getstr(tok,1); const char *varname = getstr(tok,1);
unsigned int size = strtoul(getstr(tok,3), NULL, 10); unsigned int size = strtoul(getstr(tok,3), NULL, 10);
int total_size = 0;
if (strcmp(tok->str,"char") == 0)
total_size = size * sizeof(char);
else if (strcmp(tok->str,"int") == 0)
total_size = size * sizeof(int);
else if (strcmp(tok->str,"double") == 0)
total_size = size * sizeof(double);
int _indentlevel = indentlevel; int _indentlevel = indentlevel;
for (TOKEN *tok2 = gettok(tok,5); tok2; tok2 = tok2->next) for (TOKEN *tok2 = gettok(tok,5); tok2; tok2 = tok2->next)
{ {
@ -63,6 +70,31 @@ void CheckBufferOverrun()
} }
} }
if (total_size > 0)
{
// memset, memcmp, memcpy, strncpy, fgets..
if (strcmp(tok2->str,"memset")==0 ||
strcmp(tok2->str,"memcpy")==0 ||
strcmp(tok2->str,"memcmp")==0 ||
strcmp(tok2->str,"strncpy")==0 ||
strcmp(tok2->str,"fgets")==0 )
{
if (match(tok2->next,"( var , num , num )") ||
match(tok2->next,"( var , var , num )") )
{
if (strcmp(getstr(tok2,2),varname)==0 &&
atoi(getstr(tok2,6))>total_size)
{
std::ostringstream ostr;
ostr << FileLine(tok2) << ": Buffer overrun";
ReportErr(ostr.str());
}
}
}
}
// Loop.. // Loop..
const char *strindex = 0; const char *strindex = 0;
int value = 0; int value = 0;