walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

#ticket 1513: added sqrt() support

This commit is contained in:
Martin Ettl 2010-04-05 20:20:20 +02:00
parent 93d195aa0f
commit 4bc325f077
2 changed files with 19 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/checkother.cpp
View File

@ -2563,6 +2563,12 @@ void CheckOther::checkMathFunctions()
{
mathfunctionCallError(tok);
}
// sqrt( x ): if x is negative the result is undefined
else if (Token::Match(tok, "sqrt ( %num% )") &&
MathLib::isNegative(tok->tokAt(2)->str()))
{
mathfunctionCallError(tok);
}
// atan2 ( x , y): x and y can not be zero, because this is mathematically not defined
else if (Token::Match(tok, "atan2 ( %num% , %num% )") &&
MathLib::isNullValue(tok->tokAt(2)->str()) &&

13
test/testother.cpp
View File

@ -2334,6 +2334,19 @@ private:
"}");
ASSERT_EQUALS("", errout.str());
// sqrt
check("void foo()\n"
"{\n"
" std::cout << sqrt(-1) << std::endl;\n"
"}");
ASSERT_EQUALS("[test.cpp:3]: (error) Passing value -1 to sqrt() leads to undefined result\n", errout.str());
check("void foo()\n"
"{\n"
" std::cout << sqrt(1) << std::endl;\n"
"}");
ASSERT_EQUALS("", errout.str());
}
};