cleaned up includes based on include-what-you-use (#4358)

* cleaned up includes based on include-what-you-use

* testlibrary.cpp: no need for `empyString` optimization

cli/cmdlineparser.cpp

@@ -40,6 +40,7 @@
 #include <iostream>
 #include <list>
 #include <set>
+#include <utility>
 
 #ifdef HAVE_RULES
 // xml is used for rules

cli/cppcheckexecutor.cpp

@@ -32,7 +32,6 @@
 #include "preprocessor.h"
 #include "settings.h"
 #include "suppressions.h"
-#include "threadexecutor.h"
 #include "utils.h"
 #include "checkunusedfunctions.h"
 

lib/analyzerinfo.h

@@ -24,6 +24,7 @@
 #include "config.h"
 #include "importproject.h"
 
+#include <cstddef>
 #include <fstream>
 #include <list>
 #include <string>

lib/astutils.h

@@ -26,13 +26,15 @@
 #include <set>
 #include <stack>
 #include <string>
+#include <type_traits>
+#include <utility>
 #include <vector>
 
 #include "config.h"
 #include "errortypes.h"
+#include "library.h"
 #include "symboldatabase.h"
 
-class Library;
 class Settings;
 class Token;
 

lib/checkmemoryleak.cpp

@@ -29,6 +29,7 @@
 
 #include <algorithm>
 #include <unordered_set>
+#include <utility>
 #include <vector>
 
 //---------------------------------------------------------------------------

lib/pathmatch.cpp

@@ -22,6 +22,7 @@
 #include "utils.h"
 
 #include <cstddef>
+#include <utility>
 
 PathMatch::PathMatch(std::vector<std::string> excludedPaths, bool caseSensitive)
     : mExcludedPaths(std::move(excludedPaths)), mCaseSensitive(caseSensitive)

lib/platform.cpp

@@ -20,7 +20,6 @@
 
 #include "path.h"
 
-#include <cstdlib>
 #include <cstring>
 #include <limits>
 #include <vector>

lib/preprocessor.cpp

@@ -29,8 +29,6 @@
 
 #include <algorithm>
 #include <cstddef>
-#include <cstdint>
-#include <functional>
 #include <iterator> // back_inserter
 #include <memory>
 #include <utility>

lib/preprocessor.h

@@ -24,7 +24,7 @@
 #include "config.h"
 
 #include <atomic>
-#include <simplecpp.h>
+#include <cstddef>
 #include <istream>
 #include <list>
 #include <map>
@@ -32,6 +32,8 @@
 #include <string>
 #include <vector>
 
+#include <simplecpp.h>
+
 class ErrorLogger;
 class Settings;
 

lib/symboldatabase.h

@@ -22,6 +22,7 @@
 //---------------------------------------------------------------------------
 
 #include "config.h"
+#include "errortypes.h"
 #include "library.h"
 #include "mathlib.h"
 #include "sourcelocation.h"

lib/tokenize.cpp

@@ -41,7 +41,6 @@
 #include <cstdlib>
 #include <cstring>
 #include <iostream>
-#include <iterator>
 #include <exception>
 #include <memory>
 #include <set>

lib/tokenize.h

@@ -29,8 +29,6 @@
 #include <list>
 #include <map>
 #include <string>
-#include <stack>
-#include <utility>
 #include <vector>
 
 class Settings;

lib/tokenlist.cpp

@@ -23,6 +23,7 @@
 #include "errorlogger.h"
 #include "errortypes.h"
 #include "library.h"
+#include "mathlib.h"
 #include "path.h"
 #include "settings.h"
 #include "standards.h"

lib/tokenlist.h

@@ -24,6 +24,7 @@
 #include "config.h"
 #include "token.h"
 
+#include <cstddef>
 #include <iosfwd>
 #include <string>
 #include <unordered_set>

test/testlibrary.cpp

@@ -521,7 +521,7 @@ private:
             const Library::ArgumentChecks::MinSize &m = minsizes->front();
             ASSERT(Library::ArgumentChecks::MinSize::Type::VALUE == m.type);
             ASSERT_EQUALS(500, m.value);
-            ASSERT_EQUALS(emptyString, m.baseType);
+            ASSERT_EQUALS("", m.baseType);
         }
 
         // arg5: type=value

test/testother.cpp

@@ -27,7 +27,6 @@
 #include "tokenize.h"
 
 #include <iosfwd>
-#include <list>
 #include <map>
 #include <string>
 #include <unordered_map>

test/testpreprocessor.cpp

@@ -24,6 +24,7 @@
 #include "platform.h"
 #include "preprocessor.h"
 #include "settings.h"
+#include "suppressions.h"
 #include "testsuite.h"
 #include "testutils.h"