walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Fix #11753 FN: invalidLifetime (#5128) 

* Fix #11753 FN: invalidLifetime

* Format

* Format

* Only forward for local variables

* Format

* Format
This commit is contained in:
chrchr-github 2023-06-08 07:45:59 +02:00 committed by GitHub
parent 3ff8ce316c
commit 4dbbae62a7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 34 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
lib/valueflow.cpp
View File

@ -4490,6 +4490,23 @@ static void valueFlowLifetimeFunction(Token *tok, TokenList *tokenlist, ErrorLog
// Assume constructing the valueType
valueFlowLifetimeConstructor(tok->next(), tokenlist, errorLogger, settings);
valueFlowForwardLifetime(tok->next(), tokenlist, errorLogger, settings);
} else {
const std::string& retVal = settings->library.returnValue(tok);
if (retVal.compare(0, 3, "arg") == 0) {
std::size_t iArg{};
try {
iArg = strToInt<std::size_t>(retVal.substr(3));
} catch (...) {
return;
}
std::vector<const Token*> args = getArguments(tok);
if (iArg > 0 && iArg <= args.size()) {
const Token* varTok = args[iArg - 1];
if (varTok->variable() && varTok->variable()->isLocal())
LifetimeStore{ varTok, "Passed to '" + tok->str() + "'.", ValueFlow::Value::LifetimeKind::Address }.byRef(
tok->next(), tokenlist, errorLogger, settings);
}
}
}
}

17
test/testautovariables.cpp
View File

@ -4413,6 +4413,23 @@ private:
" return 0;\n"
"}");
ASSERT_EQUALS("[test.cpp:5] -> [test.cpp:4] -> [test.cpp:8]: (error) Using pointer to local variable 'x' that is out of scope.\n", errout.str());
// #11753
check("int main(int argc, const char *argv[]) {\n"
" const char* s = \"\";\n"
" if (argc > 0) {\n"
" char buff[32]{};\n"
" s = std::strncpy(buff, argv[0], 31);\n"
" }\n"
" std::cout << s;\n"
"}\n");
ASSERT_EQUALS("[test.cpp:5] -> [test.cpp:4] -> [test.cpp:7]: (error) Using pointer to local variable 'buff' that is out of scope.\n", errout.str());
check("char* f(char* dst) {\n"
" const char* src = \"abc\";\n"
" return strcpy(dst, src);\n"
"}\n");
ASSERT_EQUALS("", errout.str());
}
void splitNamespaceAuto() { // #10473