walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Merge pull request #2731 from pfultz2/dangling-container-value-type 

Fix issue 9770: FP returnDanglingLifetime for class method taking const char* and returning std::string
This commit is contained in:
Daniel Marjamäki 2020-08-06 09:02:54 +02:00 committed by GitHub
parent 72fa5f2e27 0cc1f69862
commit 4fabd1e059
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/valueflow.cpp
View File

@ -3068,7 +3068,7 @@ static bool isLifetimeBorrowed(const ValueType *vt, const ValueType *vtParent)
return false;
if (!vt)
return false;
if (vt->type != ValueType::UNKNOWN_TYPE && vtParent->type != ValueType::UNKNOWN_TYPE) {
if (vt->type != ValueType::UNKNOWN_TYPE && vtParent->type != ValueType::UNKNOWN_TYPE && vtParent->container == vt->container) {
if (vtParent->pointer > vt->pointer)
return true;
if (vtParent->pointer < vt->pointer && vtParent->isIntegral())

10
test/testautovariables.cpp
View File

@ -2328,6 +2328,16 @@ private:
" return value;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
// #9770
check("class C {\n"
" std::string f(const char*);\n"
"};\n"
"std::string C::f(const char*) {\n"
" const char data[] = \"x\";\n"
" return data;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
}
void danglingLifetimeFunction() {