walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Merge pull request #353 from Dmitry-Me/breakLoopEarlyInsteadOfContinuingBitwiseAnd 

Break the loop once the result can no longer change.
This commit is contained in:
Daniel Marjamäki 2014-07-03 06:54:00 +02:00
parent d40b77dce2 b38e43ebae
commit 51396e52aa
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/checkassert.cpp
View File

@ -81,7 +81,10 @@ void CheckAssert::assertWithSideEffects()
bool noReturnInScope = true; bool noReturnInScope = true;
for (std::vector<const Token*>::iterator rt = returnTokens.begin(); rt != returnTokens.end(); ++rt) { for (std::vector<const Token*>::iterator rt = returnTokens.begin(); rt != returnTokens.end(); ++rt) {
noReturnInScope &= !inSameScope(*rt, tok2); if (inSameScope(*rt, tok2)) {
noReturnInScope = false;
break;
}
} }
if (noReturnInScope) continue; if (noReturnInScope) continue;
bool isAssigned = checkVariableAssignment(tok2, false); bool isAssigned = checkVariableAssignment(tok2, false);