walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Fixed slow checking in FwdAnalysis 

Credit to OSS-Fuzz for reporting this!
This commit is contained in:
Daniel Marjamäki 2019-03-30 14:22:24 +01:00
parent 8f9c4ec4a2
commit 51b64191e5
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lib/astutils.cpp
View File

@ -1388,11 +1388,14 @@ FwdAnalysis::Result FwdAnalysis::check(const Token *expr, const Token *startToke
// all variable ids in expr.
std::set<unsigned int> exprVarIds;
bool local = true;
bool unknownVarId = false;
visitAstNodes(expr,
[&](const Token *tok) {
if (tok->varId() == 0 && tok->isName() && tok->previous()->str() != ".")
// unknown variables are not local
local = false;
if (tok->varId() == 0 && tok->isName() && tok->previous()->str() != ".") {
// unknown variable
unknownVarId = true;
return ChildrenToVisit::none;
}
if (tok->varId() > 0) {
exprVarIds.insert(tok->varId());
if (!Token::simpleMatch(tok->previous(), ".")) {
@ -1406,6 +1409,9 @@ FwdAnalysis::Result FwdAnalysis::check(const Token *expr, const Token *startToke
return ChildrenToVisit::op1_and_op2;
});
if (unknownVarId)
return Result(FwdAnalysis::Result::Type::BAILOUT);
// In unused values checking we do not want to check assignments to
// global data.
if (mWhat == What::UnusedValue && isGlobalData(expr))