walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Merge pull request #965 from orbitcowboy/master 

Improved const correctness of local variables.
This commit is contained in:
orbitcowboy 2017-10-01 15:58:40 +02:00 committed by GitHub
parent 406ddc5c10 d9ef5c5a85
commit 543cf89f76
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/utils.h
View File

@ -84,8 +84,8 @@ inline static int caseInsensitiveStringCompare(const std::string &lhs, const std
if (lhs.size() != rhs.size())
return (lhs.size() < rhs.size()) ? -1 : 1;
for (unsigned int i = 0; i < lhs.size(); ++i) {
int c1 = std::toupper(lhs[i]);
int c2 = std::toupper(rhs[i]);
const int c1 = std::toupper(lhs[i]);
const int c2 = std::toupper(rhs[i]);
if (c1 != c2)
return (c1 < c2) ? -1 : 1;
}