From 5485e6866fc32943a7aad9590198d1a9d317e4cf Mon Sep 17 00:00:00 2001
From: Edoardo Prezioso <edo88@email.it>
Date: Fri, 4 Jan 2013 11:21:53 +0100
Subject: [PATCH] Fixed wrong tokenization of some math formulas:

The two formulas: sin^2+cos^2 = 1 and sinh^2-cosh^2 = -1 are true iff the two arguments are the same.
---
 lib/tokenize.cpp      |  4 ++--
 test/testtokenize.cpp | 54 ++++++++++++++++++++++++-------------------
 2 files changed, 32 insertions(+), 26 deletions(-)

diff --git a/lib/tokenize.cpp b/lib/tokenize.cpp
index 90a22b877..9c77aa60f 100644
--- a/lib/tokenize.cpp
+++ b/lib/tokenize.cpp
@@ -9350,12 +9350,12 @@ void Tokenizer::simplifyMathExpressions()
             tok->str("0");
         }
 
-        if (Token::Match(tok,"pow ( sin ( %var% ) , 2 ) + pow ( cos ( %var% ) , 2 )")) {
+        if (Token::Match(tok,"pow ( sin ( %any% ) , 2 ) + pow ( cos ( %any% ) , 2 )") && tok->strAt(4) == tok->strAt(14)) {
             tok->deleteNext(18);
             tok->str("1");
         }
 
-        if (Token::Match(tok,"pow ( sinh ( %var% ) , 2 ) - pow ( cosh ( %var% ) , 2 )")) {
+        if (Token::Match(tok,"pow ( sinh ( %any% ) , 2 ) - pow ( cosh ( %any% ) , 2 )") && tok->strAt(4) == tok->strAt(14)) {
             tok->deleteNext(18);
             tok->str("-1");
         }
diff --git a/test/testtokenize.cpp b/test/testtokenize.cpp
index 7350b0a71..9a0189c35 100644
--- a/test/testtokenize.cpp
+++ b/test/testtokenize.cpp
@@ -7714,32 +7714,38 @@ private:
     }
 
     void simplifyMathExpressions() {//#1620
-        const char *code1 ="void foo() {\n"
-                           "std::cout<<sin(0);\n"
-                           "std::cout<<cos(0);\n"
-                           "std::cout<<sinh(0);\n"
-                           "std::cout<<cosh(0);\n"
-                           "std::cout<<exp(0);\n"
-                           "std::cout<<sqrt(0);\n"
-                           "std::cout<<sqrt(1);\n"
-                           "std::cout<<ln(1);\n"
-                           "std::cout<<pow(sin(x),2)+pow(cos(x),2);\n"
-                           "std::cout<<pow(sinh(x),2)-pow(cosh(x),2);\n"
-                           "}";
+        const char code1[] = "void foo() {\n"
+                             "    std::cout<<sin(0);\n"
+                             "    std::cout<<cos(0);\n"
+                             "    std::cout<<sinh(0);\n"
+                             "    std::cout<<cosh(0);\n"
+                             "    std::cout<<exp(0);\n"
+                             "    std::cout<<sqrt(0);\n"
+                             "    std::cout<<sqrt(1);\n"
+                             "    std::cout<<ln(1);\n"
+                             "    std::cout<<pow(sin(x),2)+pow(cos(x),2);\n"
+                             "    std::cout<<pow(sinh(x),2)-pow(cosh(x),2);\n"
+                             "}";
 
-        const char *expected1 ="void foo ( ) {\n"
-                               "std :: cout << 0 ;\n"
-                               "std :: cout << 1 ;\n"
-                               "std :: cout << 0 ;\n"
-                               "std :: cout << 1 ;\n"
-                               "std :: cout << 1 ;\n"
-                               "std :: cout << 0 ;\n"
-                               "std :: cout << 1 ;\n"
-                               "std :: cout << 0 ;\n"
-                               "std :: cout << 1 ;\n"
-                               "std :: cout << -1 ;\n"
-                               "}";
+        const char expected1[] = "void foo ( ) {\n"
+                                 "std :: cout << 0 ;\n"
+                                 "std :: cout << 1 ;\n"
+                                 "std :: cout << 0 ;\n"
+                                 "std :: cout << 1 ;\n"
+                                 "std :: cout << 1 ;\n"
+                                 "std :: cout << 0 ;\n"
+                                 "std :: cout << 1 ;\n"
+                                 "std :: cout << 0 ;\n"
+                                 "std :: cout << 1 ;\n"
+                                 "std :: cout << -1 ;\n"
+                                 "}";
         ASSERT_EQUALS(expected1, tokenizeAndStringify(code1));
+
+        const char code2[] = "void f ( ) {\n"
+                             "z = pow ( sin ( x ) , 2 ) + pow ( cos ( y ) , 2 ) ;\n"
+                             "t = pow ( sinh ( x ) , 2 ) - pow ( cosh ( y ) , 2 ) ;\n"
+                             "}";
+        ASSERT_EQUALS(code2, tokenizeAndStringify(code2));
     }