walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Refactoring: use continue

This commit is contained in:
Daniel Marjamäki 2019-03-14 19:53:45 +01:00
parent 5728bd63af
commit 56c47fc6ed
1 changed files with 70 additions and 70 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/symboldatabase.cpp
View File

@ -1263,12 +1263,14 @@ void SymbolDatabase::createSymbolDatabaseUnknownArrayDimensions()
// set all unknown array dimensions // set all unknown array dimensions
for (std::size_t i = 1; i <= mTokenizer->varIdCount(); i++) { for (std::size_t i = 1; i <= mTokenizer->varIdCount(); i++) {
// check each array variable // check each array variable
if (mVariableList[i] && mVariableList[i]->isArray()) { if (!mVariableList[i] || !mVariableList[i]->isArray())
continue;
// check each array dimension // check each array dimension
const std::vector<Dimension>& dimensions = mVariableList[i]->dimensions(); const std::vector<Dimension>& dimensions = mVariableList[i]->dimensions();
for (std::size_t j = 0; j < dimensions.size(); j++) { for (std::size_t j = 0; j < dimensions.size(); j++) {
Dimension &dimension = const_cast<Dimension &>(dimensions[j]); Dimension &dimension = const_cast<Dimension &>(dimensions[j]);
if (dimension.num == 0) { if (dimension.num != 0)
continue;
dimension.known = false; dimension.known = false;
// check for a single token dimension // check for a single token dimension
if (dimension.start && (dimension.start == dimension.end)) { if (dimension.start && (dimension.start == dimension.end)) {
@ -1343,8 +1345,6 @@ void SymbolDatabase::createSymbolDatabaseUnknownArrayDimensions()
} }
} }
} }
}
}
} }
SymbolDatabase::~SymbolDatabase() SymbolDatabase::~SymbolDatabase()