From 5772bbd206fb0ffeac49aeccc2f69a4888db7482 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Marjam=C3=A4ki?= Date: Wed, 18 Nov 2015 15:56:48 +0100 Subject: [PATCH] Fix Cppcheck warning 'explicit constructor' --- lib/checkuninitvar.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/checkuninitvar.cpp b/lib/checkuninitvar.cpp index affdf3432..4a1c9a0bd 100644 --- a/lib/checkuninitvar.cpp +++ b/lib/checkuninitvar.cpp @@ -173,7 +173,7 @@ void CheckUninitVar::checkStruct(const Token *tok, const Variable &structvar) struct VariableValue { VariableValue() : notEqual(false), value(0) {} - VariableValue(MathLib::bigint val) : notEqual(false), value(val) {} + explicit VariableValue(MathLib::bigint val) : notEqual(false), value(val) {} bool notEqual; MathLib::bigint value; }; @@ -362,7 +362,7 @@ bool CheckUninitVar::checkScopeForVariable(const Token *tok, const Variable& var if (Token::Match(tok2, "[;{}.] %name% = - %name% ;")) varValueIf[tok2->next()->varId()] = !VariableValue(0); else if (Token::Match(tok2, "[;{}.] %name% = %num% ;")) - varValueIf[tok2->next()->varId()] = MathLib::toLongNumber(tok2->strAt(3)); + varValueIf[tok2->next()->varId()] = VariableValue(MathLib::toLongNumber(tok2->strAt(3))); } } @@ -392,7 +392,7 @@ bool CheckUninitVar::checkScopeForVariable(const Token *tok, const Variable& var if (Token::Match(tok2, "[;{}.] %var% = - %name% ;")) varValueElse[tok2->next()->varId()] = !VariableValue(0); else if (Token::Match(tok2, "[;{}.] %var% = %num% ;")) - varValueElse[tok2->next()->varId()] = MathLib::toLongNumber(tok2->strAt(3)); + varValueElse[tok2->next()->varId()] = VariableValue(MathLib::toLongNumber(tok2->strAt(3))); } }