From 57ebed20c4a349625ca2d2f9196fc0e45ec1e88e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Marjam=C3=A4ki?= <daniel.marjamaki@gmail.com>
Date: Tue, 10 Jul 2012 21:18:59 +0200
Subject: [PATCH] Added rule files based on rules suggested by jglathe

---
 rules/strlen-empty-str.xml | 9 +++++++++
 rules/unused-deref.xml     | 9 +++++++++
 2 files changed, 18 insertions(+)
 create mode 100644 rules/strlen-empty-str.xml
 create mode 100644 rules/unused-deref.xml

diff --git a/rules/strlen-empty-str.xml b/rules/strlen-empty-str.xml
new file mode 100644
index 000000000..eb45ccfdc
--- /dev/null
+++ b/rules/strlen-empty-str.xml
@@ -0,0 +1,9 @@
+<?xml version="1.0"?>
+<rule version="1">
+    <pattern> if \( ([!] )*?(strlen) \( \w+? \) ([>] [0] )*?\) { </pattern>
+    <message>
+        <id>StrlenEmptyString</id>
+        <severity>performance</severity>
+        <summary>Using strlen() to check if a string is empty is not efficient.</summary>
+    </message>
+</rule>
diff --git a/rules/unused-deref.xml b/rules/unused-deref.xml
new file mode 100644
index 000000000..b0e7dd442
--- /dev/null
+++ b/rules/unused-deref.xml
@@ -0,0 +1,9 @@
+<?xml version="1.0"?>
+<rule version="1">
+    <pattern> [;{}] [*] \w+? (\+\+|\-\-) ; </pattern>
+    <message>
+        <id>UnusedDeref</id>
+        <severity>style</severity>
+        <summary>Redundant * found, "*p++" is the same as "*(p++)".</summary>
+    </message>
+</rule>