walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

The case statement requires constant-expression (C, C++, C# and Java. 

Needless to simplify the calculation of a piece of code that can not compile.
This commit is contained in:
seb777 2011-09-10 17:28:32 +02:00
parent a9b4e21f60
commit 5879fe419d
2 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/tokenize.cpp
View File

@ -7832,14 +7832,14 @@ bool Tokenizer::simplifyCalculations()
ret = true; ret = true;
} }
else if (Token::Match(tok->previous(), "[=([,] 0 [+|]") || else if (Token::Match(tok->previous(), "[=([,] 0 [+|]") ||
Token::Match(tok->previous(), "return|case 0 [+|]")) Token::Match(tok->previous(), "return 0 [+|]"))
{ {
tok->deleteThis(); tok->deleteThis();
tok->deleteThis(); tok->deleteThis();
ret = true; ret = true;
} }
else if (Token::Match(tok->previous(), "[=[(,] 0 * %any% ,|]|)|;|=|%op%") || else if (Token::Match(tok->previous(), "[=[(,] 0 * %any% ,|]|)|;|=|%op%") ||
Token::Match(tok->previous(), "return|case 0 * %any% ,|:|;|=|%op%")) Token::Match(tok->previous(), "return 0 * %any% ,|;|=|%op%"))
{ {
tok->deleteNext(); tok->deleteNext();
if (tok->next()->str() == "(") if (tok->next()->str() == "(")
@ -7942,7 +7942,7 @@ bool Tokenizer::simplifyCalculations()
Token::Match(tok, "<< %num% [+-*/] %num% <<") || Token::Match(tok, "<< %num% [+-*/] %num% <<") ||
Token::Match(tok, "[(,[] %num% [|&^] %num% [];,);]") || Token::Match(tok, "[(,[] %num% [|&^] %num% [];,);]") ||
Token::Match(tok, "(|%op% %num% [+-*/] %num% )|%op%") || Token::Match(tok, "(|%op% %num% [+-*/] %num% )|%op%") ||
Token::Match(tok,"return|case %num% [+-*/] %num% ;|,|=|:|%op%")) Token::Match(tok,"return %num% [+-*/] %num% ;|,|=|%op%"))
{ {
tok = tok->next(); tok = tok->next();

5
test/testtokenize.cpp
View File

@ -5687,11 +5687,6 @@ private:
tokenizeAndStringify("int f() { return a * 1; }", true)); tokenizeAndStringify("int f() { return a * 1; }", true));
ASSERT_EQUALS("int f ( int a ) { return 0 ; }", ASSERT_EQUALS("int f ( int a ) { return 0 ; }",
tokenizeAndStringify("int f(int a) { return 0 * a; }", true)); tokenizeAndStringify("int f(int a) { return 0 * a; }", true));
ASSERT_EQUALS("bool f ( int i ) { switch ( i ) { case 15 : ; return true ; } }",
tokenizeAndStringify("bool f(int i) { switch (i) { case 10 + 5: return true; } }", true));
TODO_ASSERT_EQUALS("bool f ( int i ) { ; switch ( i ) { case 15 : ; return true ; } }",
"bool f ( int i ) { int a ; a = 10 ; int b ; b = 5 ; switch ( i ) { case a + b : return true ; } }",
tokenizeAndStringify("bool f(int i) { int a = 10; int b = 5; switch (i) { case a + b: return true; } }", true));
} }
void simplifyCompoundAssignment() void simplifyCompoundAssignment()