walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Spelling fixes

This commit is contained in:
Ville Skyttä 2017-05-30 08:03:15 +03:00
parent 389b4cdf99
commit 5ab158fec2
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/checkinternal.cpp
View File

@ -105,7 +105,7 @@ void CheckInternal::checkRedundantTokCheck()
void CheckInternal::checkRedundantTokCheckError(const Token* tok) void CheckInternal::checkRedundantTokCheckError(const Token* tok)
{ {
reportError(tok, Severity::style, "redundantTokCheck", reportError(tok, Severity::style, "redundantTokCheck",
"Unneccessary check of \"" + (tok? tok->expressionString(): emptyString) + "\", match-function already checks if it is null."); "Unnecessary check of \"" + (tok? tok->expressionString(): emptyString) + "\", match-function already checks if it is null.");
} }
void CheckInternal::checkTokenSimpleMatchPatterns() void CheckInternal::checkTokenSimpleMatchPatterns()

10
test/testinternal.cpp
View File

@ -416,35 +416,35 @@ private:
" const Token *tok;\n" " const Token *tok;\n"
" if(tok && Token::findsimplematch(tok, \"foobar\")) {};\n" " if(tok && Token::findsimplematch(tok, \"foobar\")) {};\n"
"}"); "}");
ASSERT_EQUALS("[test.cpp:3]: (style) Unneccessary check of \"tok\", match-function already checks if it is null.\n", errout.str()); ASSERT_EQUALS("[test.cpp:3]: (style) Unnecessary check of \"tok\", match-function already checks if it is null.\n", errout.str());
// findmatch // findmatch
check("void f() {\n" check("void f() {\n"
" const Token *tok;\n" " const Token *tok;\n"
" if(tok && Token::findmatch(tok, \"%str% foobar\")) {};\n" " if(tok && Token::findmatch(tok, \"%str% foobar\")) {};\n"
"}"); "}");
ASSERT_EQUALS("[test.cpp:3]: (style) Unneccessary check of \"tok\", match-function already checks if it is null.\n", errout.str()); ASSERT_EQUALS("[test.cpp:3]: (style) Unnecessary check of \"tok\", match-function already checks if it is null.\n", errout.str());
// Match // Match
check("void f() {\n" check("void f() {\n"
" const Token *tok;\n" " const Token *tok;\n"
" if(tok && Token::Match(tok, \"5str% foobar\")) {};\n" " if(tok && Token::Match(tok, \"5str% foobar\")) {};\n"
"}"); "}");
ASSERT_EQUALS("[test.cpp:3]: (style) Unneccessary check of \"tok\", match-function already checks if it is null.\n", errout.str()); ASSERT_EQUALS("[test.cpp:3]: (style) Unnecessary check of \"tok\", match-function already checks if it is null.\n", errout.str());
// simpleMatch // simpleMatch
check("void f() {\n" check("void f() {\n"
" const Token *tok;\n" " const Token *tok;\n"
" if(tok && Token::simpleMatch(tok, \"foobar\")) {};\n" " if(tok && Token::simpleMatch(tok, \"foobar\")) {};\n"
"}"); "}");
ASSERT_EQUALS("[test.cpp:3]: (style) Unneccessary check of \"tok\", match-function already checks if it is null.\n", errout.str()); ASSERT_EQUALS("[test.cpp:3]: (style) Unnecessary check of \"tok\", match-function already checks if it is null.\n", errout.str());
// Match // Match
check("void f() {\n" check("void f() {\n"
" const Token *tok;\n" " const Token *tok;\n"
" if(tok->previous() && Token::Match(tok->previous(), \"5str% foobar\")) {};\n" " if(tok->previous() && Token::Match(tok->previous(), \"5str% foobar\")) {};\n"
"}"); "}");
ASSERT_EQUALS("[test.cpp:3]: (style) Unneccessary check of \"tok->previous()\", match-function already checks if it is null.\n", errout.str()); ASSERT_EQUALS("[test.cpp:3]: (style) Unnecessary check of \"tok->previous()\", match-function already checks if it is null.\n", errout.str());
// don't report: // don't report:
// tok->previous() vs tok // tok->previous() vs tok