walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Misra: Added rule 13.1

This commit is contained in:
Daniel Marjamäki 2017-04-13 19:11:48 +02:00
parent b876249b6b
commit 5b0ee55964
2 changed files with 18 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
addons/misra-test.c
View File

@ -38,6 +38,12 @@ void misra_12_4() {
x = 123456u * 123456u; // 12.4 x = 123456u * 123456u; // 12.4
} }
void misra_13_1(int *p) {
volatile int v;
int a[3] = {0, (*p)++, 2}; // 13.1
int b[2] = {v,1}; // TODO
}
void misra_13_5() { void misra_13_5() {
if (x && (y++ < 123)){} // 13.5 if (x && (y++ < 123)){} // 13.5
} }

15
addons/misra.py
View File

@ -49,13 +49,13 @@ def bitsOfEssentialType(expr):
return INT_BITS return INT_BITS
return 0 return 0
def hasSideEffects(expr): def hasSideEffectsRecursive(expr):
if not expr: if not expr:
return False return False
if expr.str in ['++', '--', '=']: if expr.str in ['++', '--', '=']:
return True return True
# Todo: Check function calls # Todo: Check function calls
return hasSideEffects(expr.astOperand1) or hasSideEffects(expr.astOperand2) return hasSideEffectsRecursive(expr.astOperand1) or hasSideEffectsRecursive(expr.astOperand2)
def isBoolExpression(expr): def isBoolExpression(expr):
return expr and expr.str in ['!', '==', '!=', '<', '<=', '>', '>=', '&&', '||'] return expr and expr.str in ['!', '==', '!=', '<', '<=', '>', '>=', '&&', '||']
@ -214,9 +214,17 @@ def misra_12_4(data):
reportError(token, 12, 4) reportError(token, 12, 4)
break break
def misra_13_1(data):
for token in data.tokenlist:
if token.str != '=':
continue
init = token.next
if init and init.str == '{' and hasSideEffectsRecursive(init):
reportError(init,13,1)
def misra_13_5(data): def misra_13_5(data):
for token in data.tokenlist: for token in data.tokenlist:
if token.isLogicalOp and hasSideEffects(token.astOperand2): if token.isLogicalOp and hasSideEffectsRecursive(token.astOperand2):
reportError(token, 13, 5) reportError(token, 13, 5)
def misra_14_4(data): def misra_14_4(data):
@ -255,6 +263,7 @@ for arg in sys.argv[1:]:
misra_12_2(cfg) misra_12_2(cfg)
misra_12_3(cfg) misra_12_3(cfg)
misra_12_4(cfg) misra_12_4(cfg)
misra_13_1(cfg)
misra_13_5(cfg) misra_13_5(cfg)
misra_14_4(cfg) misra_14_4(cfg)
misra_15_1(cfg) misra_15_1(cfg)