walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Fix FN constParameterReference with std::array (#4999)

This commit is contained in:
chrchr-github 2023-04-21 20:33:06 +02:00 committed by GitHub
parent bda9f707cc
commit 5c7914aaa6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/checkother.cpp
View File

@ -1424,7 +1424,7 @@ void CheckOther::checkConstVariable()
continue; continue;
if (var->isStatic()) if (var->isStatic())
continue; continue;
if (var->isArray()) if (var->isArray() && !var->isStlType())
continue; continue;
if (var->isEnumType()) if (var->isEnumType())
continue; continue;

8
test/testother.cpp
View File

@ -3107,6 +3107,14 @@ private:
" }\n" " }\n"
"}\n"); "}\n");
ASSERT_EQUALS("", errout.str()); ASSERT_EQUALS("", errout.str());
check("void f(std::array<int, 2>& a) {\n"
" if (a[0]) {}\n"
"}\n"
"void g(std::array<int, 2>& a) {\n"
" a.fill(0);\n"
"}\n");
ASSERT_EQUALS("[test.cpp:1]: (style) Parameter 'a' can be declared as const array\n", errout.str());
} }
void constParameterCallback() { void constParameterCallback() {