walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Fixed ticket #459 (false positive::Member variable not initialized in constructor) 

http://sourceforge.net/apps/trac/cppcheck/ticket/459
This commit is contained in:
Slava Semushin 2009-07-17 23:50:49 +07:00
parent 7df3670128
commit 5dea30519c
2 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/checkclass.cpp
View File

@ -381,7 +381,7 @@ void CheckClass::checkConstructors(const Token *tok1, const char funcname[])
// Is it a static member variable? // Is it a static member variable?
std::ostringstream pattern; std::ostringstream pattern;
pattern << className << "::" << var->name << "="; pattern << className << " :: " << var->name << " =";
if (Token::findmatch(_tokenizer->tokens(), pattern.str().c_str())) if (Token::findmatch(_tokenizer->tokens(), pattern.str().c_str()))
continue; continue;

13
test/testclass.cpp
View File

@ -204,6 +204,19 @@ private:
" float f;\n" " float f;\n"
"};\n"); "};\n");
ASSERT_EQUALS("[test.cpp:6]: (style) Member variable not initialized in the constructor 'B::f'\n", errout.str()); ASSERT_EQUALS("[test.cpp:6]: (style) Member variable not initialized in the constructor 'B::f'\n", errout.str());
checkUninitVar("class C\n"
"{\n"
" FILE *fp;\n"
"\n"
"public:\n"
" C(FILE *fp);\n"
"};\n"
"\n"
"C::C(FILE *fp) {\n"
" C::fp = fp;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
} }
void uninitVarEnum() void uninitVarEnum()