walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

misra; implement rule 8.9

This commit is contained in:
Daniel Marjamäki 2021-07-18 10:31:52 +02:00
parent b2b214991d
commit 5f548a4b6c
2 changed files with 26 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
addons/misra.py
View File

@ -1858,6 +1858,28 @@ class MisraChecker:
if static_var and extern_var: if static_var and extern_var:
self.reportError(extern_var.nameToken, 8, 8) self.reportError(extern_var.nameToken, 8, 8)
def misra_8_9(self, cfg):
variables = {}
for scope in cfg.scopes:
if scope.type != 'Function':
continue
variables_used_in_scope = []
tok = scope.bodyStart
while tok != scope.bodyEnd:
if tok.variable and tok.variable.access == 'Global' and tok.variable.isStatic:
if tok.variable not in variables_used_in_scope:
variables_used_in_scope.append(tok.variable)
tok = tok.next
for var in variables_used_in_scope:
if var in variables:
variables[var] += 1
else:
variables[var] = 1
for var, count in variables.items():
if count == 1:
self.reportError(var.nameToken, 8, 9)
def misra_8_11(self, data): def misra_8_11(self, data):
for var in data.variables: for var in data.variables:
if var.isExtern and simpleMatch(var.nameToken.next, '[ ]') and var.nameToken.scope.type == 'Global': if var.isExtern and simpleMatch(var.nameToken.next, '[ ]') and var.nameToken.scope.type == 'Global':
@ -3579,6 +3601,7 @@ class MisraChecker:
self.executeCheck(806, self.misra_8_6, dumpfile, cfg) self.executeCheck(806, self.misra_8_6, dumpfile, cfg)
self.executeCheck(807, self.misra_8_7, dumpfile, cfg) self.executeCheck(807, self.misra_8_7, dumpfile, cfg)
self.executeCheck(808, self.misra_8_8, cfg) self.executeCheck(808, self.misra_8_8, cfg)
self.executeCheck(809, self.misra_8_9, cfg)
self.executeCheck(811, self.misra_8_11, cfg) self.executeCheck(811, self.misra_8_11, cfg)
self.executeCheck(812, self.misra_8_12, cfg) self.executeCheck(812, self.misra_8_12, cfg)
if cfgNumber == 0: if cfgNumber == 0:

3
addons/test/misra/misra-test.c
View File

@ -376,6 +376,9 @@ extern int16_t misra_8_4_count; // 8.4
static int32_t misra_8_8 = 123; static int32_t misra_8_8 = 123;
extern int32_t misra_8_8; // 8.8 8.4 extern int32_t misra_8_8; // 8.8 8.4
static int32_t misra_8_9_i; // 8.9
static int32_t misra_8_9_foo(void) { return misra_8_9_i++; }
extern int a811[]; // 8.11 8.4 extern int a811[]; // 8.11 8.4
enum misra_8_12_a { misra_a1 = 1, misra_a2 = 2, misra_a3, misra_a4 = 3 }; //8.12 enum misra_8_12_a { misra_a1 = 1, misra_a2 = 2, misra_a3, misra_a4 = 3 }; //8.12