walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Fixed #4357: Wrongly configured slot caused Ok() handler being not called.

This commit is contained in:
PKEuS 2012-11-30 12:38:41 +01:00
parent 29263e63fe
commit 5f8496407f
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
gui/applicationdialog.cpp
View File

@ -34,7 +34,7 @@ ApplicationDialog::ApplicationDialog(const QString &title,
mUI.setupUi(this);
connect(mUI.mButtonBrowse, SIGNAL(clicked()), this, SLOT(Browse()));
connect(mUI.mButtons, SIGNAL(accepted()), this, SLOT(accept()));
connect(mUI.mButtons, SIGNAL(accepted()), this, SLOT(Ok()));
connect(mUI.mButtons, SIGNAL(rejected()), this, SLOT(reject()));
mUI.mPath->setText(app.getPath());
mUI.mName->setText(app.getName());
@ -70,21 +70,22 @@ void ApplicationDialog::Browse()
void ApplicationDialog::Ok()
{
if (mUI.mName->text().isEmpty() || mUI.mPath->text().isEmpty() ||
mUI.mParameters->text().isEmpty()) {
if (mUI.mName->text().isEmpty() || mUI.mPath->text().isEmpty()) {
QMessageBox msg(QMessageBox::Warning,
tr("Cppcheck"),
tr("You must specify a name, a path and parameters for the application!"),
tr("You must specify a name, a path and optionally parameters for the application!"),
QMessageBox::Ok,
this);
msg.exec();
reject();
} else {
// Convert possible native (Windows) path to internal presentation format
mApplication.setName(mUI.mName->text());
mApplication.setPath(QDir::fromNativeSeparators(mUI.mPath->text()));
mApplication.setParameters(mUI.mParameters->text());
accept();
}
}