walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Fixed #1605 (false positive: uninitialized variable)

This commit is contained in:
Robert Reif 2010-04-16 16:25:57 +02:00 committed by Daniel Marjamäki
parent 45573ad101
commit 61b5a21ac9
2 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/checkother.cpp
View File

@ -660,7 +660,7 @@ void CheckOther::functionVariableUsage()
else if (Token::Match(tok, "%var% =")) else if (Token::Match(tok, "%var% ="))
varUsage[tok->str()].write = true; varUsage[tok->str()].write = true;
else if (Token::Match(tok, "%var% [ %any% ] =")) else if (Token::Match(tok, "%var% [") && Token::Match(tok->next()->link(), "] ="))
varUsage[tok->str()].write = true; varUsage[tok->str()].write = true;
else if (Token::Match(tok, "else %var% =")) else if (Token::Match(tok, "else %var% ="))

13
test/testunusedvar.cpp
View File

@ -69,6 +69,7 @@ private:
TEST_CASE(localvar6); TEST_CASE(localvar6);
TEST_CASE(localvar7); TEST_CASE(localvar7);
TEST_CASE(localvar8); TEST_CASE(localvar8);
TEST_CASE(localvar9); // ticket #1605
TEST_CASE(localvarasm); TEST_CASE(localvarasm);
// Don't give false positives for variables in structs/unions // Don't give false positives for variables in structs/unions
@ -525,6 +526,18 @@ private:
ASSERT_EQUALS("", errout.str()); ASSERT_EQUALS("", errout.str());
} }
void localvar9()
{
// ticket #1605
functionVariableUsage("void foo()\n"
"{\n"
" int a[10];\n"
" for (int i = 0; i < 10; )\n"
" a[i++] = 0;\n"
"}\n");
ASSERT_EQUALS("[test.cpp:2]: (style) Variable 'a' is assigned a value that is never used\n", errout.str());
}
void localvarasm() void localvarasm()
{ {
functionVariableUsage("void foo(int &b)\n" functionVariableUsage("void foo(int &b)\n"