walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Fix crash in constPointer() (#4945)

This commit is contained in:
chrchr-github 2023-04-09 16:38:09 +02:00 committed by GitHub
parent 7726a5b5b3
commit 63151f3291
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/checkother.cpp
View File

@ -1478,7 +1478,7 @@ void CheckOther::checkConstVariable()
else else
opTok = opTok->astOperand2(); opTok = opTok->astOperand2();
} }
if (opTok->valueType() && var->valueType() && opTok->valueType()->isConst(var->valueType()->pointer)) if (opTok && opTok->valueType() && var->valueType() && opTok->valueType()->isConst(var->valueType()->pointer))
continue; continue;
} else if (const Token* ftok = getTokenArgumentFunction(tok, argn)) { } else if (const Token* ftok = getTokenArgumentFunction(tok, argn)) {
bool inconclusive{}; bool inconclusive{};

6
test/testother.cpp
View File

@ -3486,6 +3486,12 @@ private:
"}\n"); "}\n");
ASSERT_EQUALS("", errout.str()); // don't crash ASSERT_EQUALS("", errout.str()); // don't crash
check("void f(int& i) {\n"
" int& r = i;\n"
" if (!&r) {}\n"
"}\n");
TODO_ASSERT_EQUALS("[test.cpp:2]: (style) Variable 'r' can be declared as reference to const\n", "", errout.str()); // don't crash
check("class C;\n" // #11646 check("class C;\n" // #11646
"void g(const C* const p);\n" "void g(const C* const p);\n"
"void f(C* c) {\n" "void f(C* c) {\n"