walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Fix 11636: FP nullPointer with uninstantiated template (#5004) 

* Fix 11636: FP nullPointer with uninstantiated template

* Format
This commit is contained in:
Paul Fultz II 2023-04-23 07:40:03 -05:00 committed by GitHub
parent 1b9369b78b
commit 6820b70dd1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/programmemory.cpp
View File

@ -1416,7 +1416,7 @@ static ValueFlow::Value execute(const Token* expr, ProgramMemory& pm, const Sett
return v; return v;
if (!expr) if (!expr)
return v; return v;
if (pm.hasValue(expr->exprId())) if (expr->exprId() > 0 && pm.hasValue(expr->exprId()))
return pm.at(expr->exprId()); return pm.at(expr->exprId());
if (const ValueFlow::Value* value = getImpossibleValue(expr)) if (const ValueFlow::Value* value = getImpossibleValue(expr))
return *value; return *value;

12
test/testnullpointer.cpp
View File

@ -143,6 +143,7 @@ private:
TEST_CASE(nullpointer97); // #11229 TEST_CASE(nullpointer97); // #11229
TEST_CASE(nullpointer98); // #11458 TEST_CASE(nullpointer98); // #11458
TEST_CASE(nullpointer99); // #10602 TEST_CASE(nullpointer99); // #10602
TEST_CASE(nullpointer100); // #11636
TEST_CASE(nullpointer_addressOf); // address of TEST_CASE(nullpointer_addressOf); // address of
TEST_CASE(nullpointerSwitch); // #2626 TEST_CASE(nullpointerSwitch); // #2626
TEST_CASE(nullpointer_cast); // #4692 TEST_CASE(nullpointer_cast); // #4692
@ -2830,6 +2831,17 @@ private:
ASSERT_EQUALS("[test.cpp:14]: (error) Null pointer dereference: buf\n", errout.str()); ASSERT_EQUALS("[test.cpp:14]: (error) Null pointer dereference: buf\n", errout.str());
} }
void nullpointer100() // #11636
{
check("const char* type_of(double) { return \"unknown\"; }\n"
"void f() {\n"
" double tmp = 0.0;\n"
" const char* t = type_of(tmp);\n"
" std::cout << t;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
}
void nullpointer_addressOf() { // address of void nullpointer_addressOf() { // address of
check("void f() {\n" check("void f() {\n"
" struct X *x = 0;\n" " struct X *x = 0;\n"