walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

misra: implement rule 21.21

This commit is contained in:
Daniel Marjamäki 2021-08-15 13:38:04 +02:00
parent 10c2dcf721
commit 6ddb8388ed
2 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
addons/misra.py
View File

@ -1091,7 +1091,7 @@ def generateTable():
numberOfRules[18] = 8
numberOfRules[19] = 2
numberOfRules[20] = 14
numberOfRules[21] = 12
numberOfRules[21] = 21
numberOfRules[22] = 10
# Rules that can be checked with compilers:
@ -3404,7 +3404,7 @@ class MisraChecker:
def misra_21_8(self, data):
for token in data.tokenlist:
if isFunctionCall(token) and (token.astOperand1.str in ('abort', 'exit', 'getenv', 'system')):
if isFunctionCall(token) and (token.astOperand1.str in ('abort', 'exit', 'getenv')):
self.reportError(token, 21, 8)
def misra_21_9(self, data):
@ -3456,6 +3456,13 @@ class MisraChecker:
continue
self.reportError(token, 21, 15)
def misra_21_21(self, cfg):
for token in cfg.tokenlist:
if token.str == 'system':
name, args = cppcheckdata.get_function_call_name_args(token)
if name == 'system' and len(args) == 1:
self.reportError(token, 21, 21)
def misra_22_5(self, cfg):
for token in cfg.tokenlist:
if token.isUnaryOp("*") or (token.isBinaryOp() and token.str == '.'):
@ -4093,6 +4100,7 @@ class MisraChecker:
self.executeCheck(2111, self.misra_21_11, cfg)
self.executeCheck(2112, self.misra_21_12, cfg)
self.executeCheck(2115, self.misra_21_15, cfg)
self.executeCheck(2121, self.misra_21_21, cfg)
# 22.4 is already covered by Cppcheck writeReadOnlyFile
self.executeCheck(2205, self.misra_22_5, cfg)
self.executeCheck(2207, self.misra_22_7, cfg)

5
addons/test/misra/misra-test.c
View File

@ -1623,7 +1623,6 @@ static void misra_21_7(void) {
static void misra_21_8(void) {
abort(); // 21.8
(void)getenv("foo"); // 21.8
(void)system(""); // 21.8
exit(-1); // 21.8
}
@ -1782,6 +1781,10 @@ static uint8_t misra_13_1_large_bad[1024] = { // 13.1
0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF
};
static void misra_21_21(void) {
(void)system("ls"); // 21.21
}
static void misra_22_5(FILE *f) {
int x = *f; // 22.5
int y = f->pos; // 22.5