walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Avoid std::string::pop_back() as long as travis uses an ancient standard library version

This commit is contained in:
PKEuS 2016-12-05 22:55:57 +01:00
parent 6e8ac13325
commit 6dfbddef43
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/importproject.cpp
View File

@ -72,7 +72,7 @@ void ImportProject::FileSettings::setDefines(std::string defs)
while (defs.find(";;") != std::string::npos) while (defs.find(";;") != std::string::npos)
defs.erase(defs.find(";;"),1); defs.erase(defs.find(";;"),1);
if (!defs.empty() && defs.back() == ';') if (!defs.empty() && defs.back() == ';')
defs.pop_back(); defs.erase(defs.size() - 1U); // TODO: Use std::string::pop_back() as soon as travis supports it
bool eq = false; bool eq = false;
for (std::size_t pos = 0; pos < defs.size(); ++pos) { for (std::size_t pos = 0; pos < defs.size(); ++pos) {
if (defs[pos] == '(' || defs[pos] == '=') if (defs[pos] == '(' || defs[pos] == '=')
@ -131,7 +131,7 @@ void ImportProject::FileSettings::setIncludePaths(const std::string &basepath, c
} }
if (s.back() == '/') // this is a temporary hack, simplifyPath can crash if path ends with '/' if (s.back() == '/') // this is a temporary hack, simplifyPath can crash if path ends with '/'
s.pop_back(); s.erase(s.size() - 1U); // TODO: Use std::string::pop_back() as soon as travis supports it
if (s.find("$(")==std::string::npos) { if (s.find("$(")==std::string::npos) {
s = Path::simplifyPath(basepath + s); s = Path::simplifyPath(basepath + s);